Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(typescript-eslint): tolerate spaces and other path cases in inferred tsconfigRootDir paths#11408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
…est.tsCo-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Thanks for the PR,@JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedJul 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedJul 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commit22fc507
☁️Nx Cloud last updated this comment at |
codecovbot commentedJul 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #11408 +/- ##======================================= Coverage 90.86% 90.86% ======================================= Files 503 503 Lines 51037 51029 -8 Branches 8424 8418 -6 =======================================- Hits 46374 46367 -7 Misses 4648 4648+ Partials 15 14 -1
Flags with carried forward coverage won't be shown.Click here to find out more.
🚀 New features to boost your workflow:
|
| @@ -2,7 +2,10 @@ import { fileURLToPath } from 'node:url'; | |||
| export function getTSConfigRootDirFromStack(stack: string): string | undefined { | |||
| for (const line of stack.split('\n').map(line => line.trim())) { | |||
| const candidate = /(\S+)eslint\.config\.(c|m)?(j|t)s/.exec(line)?.[1]; | |||
| const candidate = /(.+?)[/\\]+eslint\.config\.(c|m)?(j|t)s/ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is so cursed 😍
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
This is a bit of a band-aid fix: it makes the original regular expression allow spaces, then manually removes the
atorat asyncfrom the line. I think a better long-term strategy would be to go with what@kirkwaiblinger suggested of a more formal error stack trace parser. But I'd really like to get this fixed ASAP.Note that this mostly only conflicts with#11406 in terms of lines touched. We should be able to merge one after the other with minimal conflict resolution.
💖
Co-authored-by:@kirkwaiblinger