Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
test(typescript-estree): enable more alignment tests#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| * TODO: remove me in next babel > 7.2.3 | ||
| * Was expected to be fixed by PR into Babel: https://github.com/babel/babel/pull/9302 | ||
| * But not fixed in Babel 7.3 | ||
| * TODO: Investigate differences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
in babel i implemented this in a little diffrent way.
we have one node TSImportType with property isTypeOf set to true/false (as is in ts)
in babel its 2 nodes: typeof -> TSImportType
spliting this node to 2 allows us to handle comments in between themtypeof /* test */ import
Codecov Report
@@ Coverage Diff @@## master #114 +/- ##======================================= Coverage 94.83% 94.83% ======================================= Files 48 48 Lines 2480 2480 Branches 381 381 ======================================= Hits 2352 2352 Misses 77 77 Partials 51 51
|
| * TODO: remove me in next babel > 7.2.3 | ||
| * Was expected to be fixed by PR into Babel: https://github.com/babel/babel/pull/9284 | ||
| * But not fixed in Babel 7.3 | ||
| * TODO: Investigate differences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks like we have issue with ranges,TSParameterProperty->AssignmentPatternAssignmentPattern includes modifier into their range
but modifier is attached toTSParameterProperty
No description provided.