typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix: disallow extra properties in rule options#11397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

andreww2012 wants to merge3 commits intotypescript-eslint:main

base:main

Choose a base branch

fromandreww2012:fix/disallow-extra-properties-in-rule-options

Open

fix: disallow extra properties in rule options#11397

andreww2012 wants to merge3 commits intotypescript-eslint:mainfromandreww2012:fix/disallow-extra-properties-in-rule-options

+4 −2

Conversation

Copy link

andreww2012 commentedJul 14, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue: fixesBug: schemas of some rules allow extra properties #11396
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR simply disallows extra properties in rules' schemas which currently allow them.

fix: disallow extra properties in rule options

2b15681

Copy link

Contributor

typescript-eslintbot commentedJul 14, 2025

Thanks for the PR,@andreww2012!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 14, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4ba7bb5`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6876ad576c893e00088b684c
😎 Deploy Preview	https://deploy-preview-11397--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🟢 up 1 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedJul 14, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit4ba7bb5

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 23s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗

☁️Nx Cloud last updated this comment at2025-07-18 11:24:51 UTC

chore: regenerate schema snapshots

1945e31

Copy link

Author

andreww2012 commentedJul 14, 2025

I followed"Updating Snapshots" section in the contributing guide, but runningyarn test schemas -u failed with "NX Cannot find project 'schemas'" error for me. I had to usenpx vitest -u tests/schemas.test.ts from the same directory.

Copy link

codecovbot commentedJul 14, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base(16c344e) to head(4ba7bb5).
Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11397   +/-   ##=======================================  Coverage   90.85%   90.86%           =======================================  Files         501      503    +2       Lines       50987    51038   +51       Branches     8410     8424   +14     =======================================+ Hits        46324    46375   +51  Misses       4648     4648             Partials       15       15

Flag	Coverage Δ
unittest	`90.86% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...es/eslint-plugin/src/rules/prefer-destructuring.ts	`100.00% <100.00%> (ø)`
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`98.27% <100.00%> (+<0.01%)`	⬆️

... and6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.