typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(typescript-estree): forbid optional chain in`TemplateTaggedLiteral`#11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 9 commits intotypescript-eslint:mainfromasdf93074:feat/11352

Jul 18, 2025

Merged

feat(typescript-estree): forbid optional chain in`TemplateTaggedLiteral`#11391

bradzacher merged 9 commits intotypescript-eslint:mainfromasdf93074:feat/11352

Jul 18, 2025

+68 −1

Conversation

Copy link

Contributor

asdf93074 commentedJul 10, 2025

PR Checklist

Addresses an existing open issue:fixesEnhancement: Forbid optional chaining inTaggedTemplateExpression #11352
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Title. Do guide me if I'm missing things, not super familiar with the codebase.

asdf93074 added2 commits

July 10, 2025 22:02

Throw error if trying to optional chain in template tagged literal.

be424f9

No optional chain in tag.

d164b79

Copy link

Contributor

typescript-eslintbot commentedJul 10, 2025

Thanks for the PR,@asdf93074!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 10, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`64e3ba9`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6878d8227df62800083aad2b
😎 Deploy Preview	https://deploy-preview-11391--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🟢 up 3 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedJul 10, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit64e3ba9

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 22s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 16s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 11s	View ↗
`nx run types:build`	✅ Succeeded	4s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	7s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-07-17 11:13:22 UTC

asdf93074 changed the title~~feat(11352): forbid optional chain inTemplateTaggedLiteral.~~feat(typescript-estree): forbid optional chain inTemplateTaggedLiteral.

Jul 10, 2025

asdf93074 changed the title~~feat(typescript-estree): forbid optional chain inTemplateTaggedLiteral.~~feat(typescript-estree): forbid optional chain inTemplateTaggedLiteral

Jul 10, 2025

Copy link

codecovbot commentedJul 10, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is0% with8 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base(0e884c7) to head(64e3ba9).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	0.00%	8 Missing⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11391      +/-   ##==========================================- Coverage   90.86%   90.85%   -0.02%==========================================  Files         503      503                Lines       51037    51044       +7       Branches     8424     8424              ==========================================  Hits        46374    46374- Misses       4648     4655       +7  Partials       15       15

Flag	Coverage Δ
unittest	`90.85% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/convert.ts	`30.20% <0.00%> (-0.07%)`	⬇️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.