Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: remove deprecated RuleContext types#11386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
cseas wants to merge6 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromcseas:feat-remove-deprecated-rulecontext-types

Conversation

cseas
Copy link
Contributor

PR Checklist

Overview

Removed deprecated types as mentioned in#11371 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@cseas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 8, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitc047df6
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/686e1ccd33e3fe00083ae64c
😎 Deploy Previewhttps://deploy-preview-11386--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🟢 up 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 8, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitc047df6

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 4sView ↗
nx run-many -t lint✅ Succeeded3m 17sView ↗
nx run-many -t typecheck✅ Succeeded2m 9sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded9sView ↗
nx run types:build✅ Succeeded4sView ↗
nx run integration-tests:test✅ Succeeded4sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run generate-configs✅ Succeeded6sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-09 07:52:17 UTC

Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we can only remove the 4 methods removed ineslint/eslint#19910.

Others (such asgetPhysicalFilename()) may be deprecated but still exist, and are documented athttps://eslint.org/docs/latest/extend/custom-rules#the-context-object

@kirkwaiblingerkirkwaiblinger added the awaiting responseIssues waiting for a reply from the OP or another party labelJul 8, 2025
@cseas
Copy link
ContributorAuthor

Now the PR only removes the 4 methods removed ineslint/eslint#19910

kirkwaiblinger reacted with thumbs up emoji

Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@kirkwaiblingerkirkwaiblinger added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting responseIssues waiting for a reply from the OP or another party labelsJul 9, 2025
@bradzacherbradzacher added the breaking changeThis change will require a new major version to be released labelJul 13, 2025
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this looks good but removing these is a breaking change that will need to wait for the next major

@bradzacherbradzacher added this to the9.0.0 milestoneJul 13, 2025
@kirkwaiblinger
Copy link
Member

@bradzacher If the methods don't exist at runtime, is it really breaking or fixing?

@bradzacher
Copy link
Member

They do exist if the user is on v8.57.0 - which is the minimum version we support.

Around half of our users are on that version right now.

kirkwaiblinger reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergebreaking changeThis change will require a new major version to be released
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Enhancement: Bug: remove typings forcontext.markVariableAsUsed() and friends?
3 participants
@cseas@kirkwaiblinger@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp