Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: remove vestiges of Jest internally#11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
cseas wants to merge1 commit intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromcseas:cleanup-jest

Conversation

cseas
Copy link
Contributor

PR Checklist

Overview

Removed mentions of Jest mentioned in#11078 (review) along with some other places I could find.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@cseas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 8, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitc253892
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/686cdbab369e39000830fea1
😎 Deploy Previewhttps://deploy-preview-11385--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🟢 up 8 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 8, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitc253892

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 3sView ↗
nx run-many -t lint✅ Succeeded3m 12sView ↗
nx run-many -t typecheck✅ Succeeded2m 1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run types:build✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded1sView ↗
nx run generate-configs✅ Succeeded6sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-08 09:01:09 UTC

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commentedJul 9, 2025•
edited
Loading

FYI@aryaemami59 /@43081j

@43081j
Copy link
Contributor

looks good to me 👍

Copy link
Contributor

@aryaemami59aryaemami59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great.

@kirkwaiblinger
Copy link
Member

Looks like there are still a handful of mentions to be cleaned up?

[Jest snapshots](https://jestjs.io/docs/snapshot-testing) are generated for use in some tests, e.g. for[rule schemas](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/tests/schema-snapshots) and[code examples in rule docs](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin/tests/docs-eslint-output-snapshots). You may need to re-generate these snapshots after adjusting a rule and/or its documentation, by running the relevant test suite(s) with the`-u` flag:

- All lines are covered per the Codecov /`yarn jest path/to/impacted/file --coverage` report.

Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(see comment)

@kirkwaiblingerkirkwaiblinger added the awaiting responseIssues waiting for a reply from the OP or another party labelJul 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aryaemami59aryaemami59aryaemami59 left review comments

@kirkwaiblingerkirkwaiblingerkirkwaiblinger requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Remove vestiges of Jest internally
4 participants
@cseas@kirkwaiblinger@43081j@aryaemami59
[8]ページ先頭
©2009-2025 Movatter.jp