Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(type-utils): add missing 'types' dependency to 'type-utils'#11383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mrginglymus
Copy link
Contributor

@mrginglymusmrginglymus commentedJul 8, 2025
edited
Loading

PR Checklist

Overview

#10670 added an import from@typescript-eslint/types to@typescript-eslint/type-utils. However, the former is not present in the latters dependencies so strict pacakge managers (e.g. yarn pnp) will throw an error.

This PR adds the dependency.

hpedrorodrigues, Silic0nS0ldier, jkowalleck, and yongsk0066 reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mrginglymus!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 8, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitbe8f3e4
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/686cc2e424c419000868de92
😎 Deploy Previewhttps://deploy-preview-11383--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 8, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commitbe8f3e4

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 8sView ↗
nx run-many -t lint✅ Succeeded3m 13sView ↗
nx run-many -t typecheck✅ Succeeded2m 2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded9sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-08 07:14:34 UTC

@mrginglymusmrginglymus changed the titlefix(type-utils): Add missing 'types' dependency to 'type-utils'fix(type-utils): Add missing 'types' dependency to 'type-utils'.Jul 8, 2025
@mrginglymusmrginglymus changed the titlefix(type-utils): Add missing 'types' dependency to 'type-utils'.fix(type-utils): add missing 'types' dependency to 'type-utils'Jul 8, 2025
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oops thanks for this!

mrginglymus reacted with heart emoji
@bradzacherbradzacher merged commit5c5e3d5 intotypescript-eslint:mainJul 8, 2025
71 of 76 checks passed
@mrginglymusmrginglymus deleted the transitive-import branchJuly 8, 2025 09:41
@hpedrorodrigues
Copy link

Hey 👋🏻

First of all, thanks for the project and this pull request.

Is there a chance you can release a new patch version with this fix? This is blocking the update to the latest minor version.

@bradzacher
Copy link
Member

It will release in a few days
https://typescript-eslint.io/users/releases

hpedrorodrigues and jkowalleck reacted with thumbs up emoji

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Transitive import of @typescript-eslint/types from @typescript-eslint/type-utils
3 participants
@mrginglymus@hpedrorodrigues@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp