Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [unified-signatures] fix false positives for ignoreOverloadsWithDifferentJSDoc option#11381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

y-hsgw
Copy link
Contributor

@y-hsgwy-hsgw commentedJul 7, 2025•
edited
Loading

PR Checklist

Overview

This PR modifies the unified-signatures rule so that, when checking TSEmptyBodyFunctionExpression nodes, it also inspects the parent MethodDefinition for JSDoc comments. This ensures ignoreOverloadsWithDifferentJSDoc works correctly for class methods.

☀️

CarsonF and Park-Jongseok reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 7, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitee2ea85
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/686bd4cc24c41900085ca519
😎 Deploy Previewhttps://deploy-preview-11381--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 97 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 92 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 7, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitee2ea85

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 5sView ↗
nx run-many -t lint✅ Succeeded3m 17sView ↗
nx run-many -t typecheck✅ Succeeded2m 10sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded6sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-07 14:19:15 UTC

@codecovCodecov
Copy link

codecovbot commentedJul 7, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base(5e3288a) to head(ee2ea85).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11381      +/-   ##==========================================+ Coverage   90.84%   90.85%   +0.01%==========================================  Files         501      501                Lines       50919    50984      +65       Branches     8387     8408      +21     ==========================================+ Hits        46256    46321      +65  Misses       4648     4648                Partials       15       15
FlagCoverage Δ
unittest90.85% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...ages/eslint-plugin/src/rules/unified-signatures.ts94.33% <100.00%> (+0.06%)⬆️

... and2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nicely done 💯 thanks!

y-hsgw reacted with rocket emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commite1b310c intotypescript-eslint:mainJul 14, 2025
74 of 76 checks passed
@y-hsgwy-hsgw deleted the fix/unified-signatures branchJuly 14, 2025 11:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [unified-signatures] not ignoring different jsdocs
2 participants
@y-hsgw@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp