Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(typescript-estree): infer tsconfigRootDir from call stack#11370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJul 3, 2025
edited
Loading

PR Checklist

Overview

Adds a trio of logical pieces:

  1. candidateTSConfigRootDirs: stores candidate root directories insidetypescript-estree, exposed viaadd*,clear*, andget* functions
    • Theget*,getInferredTSConfigRootDir, will throw an error if multiple candidates have been populated. It's only called bycreateParseSettings if notsconfigRootDir was explicitly provided.
  2. getTSConfigRootDirFromStack: given a call stack, gets the candidate directory hosting an ESLint config file -- if it can be found
  3. createConfigsGetters: wraps the configs intypescript-eslint with getters that pass the result ofgetRootDirFromStack tocandidateTSConfigRootDirs

The result is that using any configs liketseslint.configs.recommendedTypeChecked will attempt to populate a candidatetsconfigRootDir for parse settings.

💖

lishaduck reacted with rocket emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJul 3, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit718b881
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/686eeed8b40e270008afc7d6
😎 Deploy Previewhttps://deploy-preview-11370--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJul 3, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit718b881

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 15sView ↗
nx run-many -t lint✅ Succeeded3m 11sView ↗
nx run-many -t typecheck✅ Succeeded2m 12sView ↗
nx test typescript-estree --coverage=false✅ Succeeded20sView ↗
nx run integration-tests:test✅ Succeeded7sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-09 22:47:39 UTC

@codecovCodecov
Copy link

codecovbot commentedJul 4, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base(16c344e) to head(718b881).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11370   +/-   ##=======================================  Coverage   90.85%   90.86%           =======================================  Files         501      503    +2       Lines       50987    51028   +41       Branches     8410     8421   +11     =======================================+ Hits        46324    46365   +41  Misses       4648     4648             Partials       15       15
FlagCoverage Δ
unittest90.86% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...pescript-eslint/src/getTSConfigRootDirFromStack.ts100.00% <100.00%> (ø)
packages/typescript-estree/src/clear-caches.ts100.00% <100.00%> (ø)
...ree/src/parseSettings/candidateTSConfigRootDirs.ts100.00% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts92.18% <100.00%> (+0.04%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJuly 4, 2025 14:11
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamJuly 4, 2025 14:11
bradzacher
bradzacher previously approved these changesJul 9, 2025
@@ -3,8 +3,10 @@ import type { TSESLint } from '@typescript-eslint/utils';

importpluginBasefrom'@typescript-eslint/eslint-plugin';
importrawPluginfrom'@typescript-eslint/eslint-plugin/use-at-your-own-risk/raw-plugin';
import{addCandidateTSConfigRootDir}from'@typescript-eslint/typescript-estree';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this adds dependency on a transitive dep -- which will break consumers.
the dep needs to be listed in thepackage.json

there's something with our lint config -- there should be likeimport/no-extraneous-deps or something that's covering this.

JoshuaKGoldberg reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thinkimport-x would have caught this 😄

@JoshuaKGoldbergJoshuaKGoldberg merged commit7126c3a intotypescript-eslint:mainJul 14, 2025
64 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the infer-tsconfigrootdir-candidates branchJuly 14, 2025 11:37
@chabbchabb mentioned this pull requestJul 15, 2025
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@kirkwaiblingerkirkwaiblingerAwaiting requested review from kirkwaiblinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: DefaulttsconfigRootDir to the running flat config's directory if available
2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp