Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-deprecated] should report deprecated exports and reexports#11359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mainframev wants to merge6 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
frommainframev:fix/no-deprecated-rule-support-exports-reexports

Conversation

mainframev
Copy link

@mainframevmainframev commentedJun 30, 2025•
edited
Loading

PR Checklist

Overview

  • Removed skipping of export statements fromisInsideExportOrImport guard function and renamed it toisInsideImport to skip only imports.
  • Updated the test file with export / reexports cases

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mainframev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 30, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4ebcabc
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/687798cb0e9b3400088cef15
😎 Deploy Previewhttps://deploy-preview-11359--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 91 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 30, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit4ebcabc

CommandStatusDurationResult
nx run-many -t typecheck❌ Failed2m 23sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx run-many --target=build --parallel --exclude...✅ Succeeded20sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-16 12:30:45 UTC

@mainframevmainframev changed the titlefix(eslint-plugin)[no-deprecated]: should report deprecated exports and reexportsfix(eslint-plugin):[no-deprecated] should report deprecated exports and reexportsJun 30, 2025
@mainframevmainframev changed the titlefix(eslint-plugin):[no-deprecated] should report deprecated exports and reexportsfix(eslint-plugin): [no-deprecated] should report deprecated exports and reexportsJun 30, 2025
@codecovCodecov
Copy link

codecovbot commentedJun 30, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is92.50000% with3 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base(3f58afe) to head(4ebcabc).

Files with missing linesPatch %Lines
packages/eslint-plugin/src/rules/no-deprecated.ts92.50%3 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main   #11359      +/-   ##==========================================- Coverage   90.86%   90.86%   -0.01%==========================================  Files         503      503                Lines       51036    51063      +27       Branches     8424     8433       +9     ==========================================+ Hits        46373    46397      +24- Misses       4648     4651       +3  Partials       15       15
FlagCoverage Δ
unittest90.86% <92.50%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts96.37% <92.50%> (-0.61%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mainframevmainframevforce-pushed thefix/no-deprecated-rule-support-exports-reexports branch from51cabaf todd8869bCompareJune 30, 2025 18:47
@mainframevmainframev marked this pull request as ready for reviewJune 30, 2025 20:25
@mainframevmainframev marked this pull request as draftJuly 2, 2025 10:29
@mainframevmainframevforce-pushed thefix/no-deprecated-rule-support-exports-reexports branch fromd81f2e1 toa1d06d3CompareJuly 2, 2025 11:32
@mainframevmainframev marked this pull request as ready for reviewJuly 2, 2025 11:53
const symbol = services.getSymbolAtLocation(node.exported);

if (searchForDeprecationInAliasesChain(symbol, false) == null) {
checkIdentifier(node.exported as TSESTree.Identifier);
Copy link
Contributor

@nayounsangnayounsangJul 4, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

safer to use conditional statements than type casting.

if(searchForDeprecationInAliasesChain(symbol,false)==null&&node.exported.type===AST_NODE_TYPES.Identifier){checkIdentifier(node.exported);}

or

functioncheckIdentifier(node:IdentifierLike|TSESTree.StringLiteral):void

It seems like a rare case, this is example of literal.

export{fooas'bar'}from'baz';export{'foo'}from'bar';

(Maybe, there will be no problem in operation. Could you test these cases?)

Copy link
Author

@mainframevmainframevJul 8, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nayounsang hi, thanks! updated 👍🏻

export { 'deprecatedFunction' } from './deprecated';
`,
`
export { deprecatedFunction as 'bar' } from './deprecated';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, I think this is far from a real-world use case and can be safely ignored. But, this tc is dupe:export { deprecatedFunction as 'bur' } from './deprecated';

mainframev reacted with thumbs up emoji
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nayounsang removed, thanks!

Also, I’ve tweaked it again a bit. While tests and lint were passing locally, on our side CI lint step was getting stuck in an infinite loop. After updating thesearchForDeprecationInAliasesChain to handle alias chains, the hang no longer occurs

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nayounsangnayounsangnayounsang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] doesn't work on export/re-export statements
2 participants
@mainframev@nayounsang
[8]ページ先頭
©2009-2025 Movatter.jp