Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-eslint): supportbasePath intseslint.config()#11357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedJun 30, 2025•
edited
Loading

PR Checklist

Overview

Adaptshttps://github.com/eslint/rewrite/pull/223/files#diff-a42aaf8268f1b91836794b8203043694f266efcd4bc078af6091e13481d3d694 for our config helper.

Co-authored-by:@ntnyq

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 30, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita299f95
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/686bf2921f7b3000084c7ee4
😎 Deploy Previewhttps://deploy-preview-11357--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (no change from production)
Accessibility: 97 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 92 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 30, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commita299f95

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 6sView ↗
nx run-many -t lint✅ Succeeded3m 10sView ↗
nx run-many -t typecheck✅ Succeeded2m 9sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded9sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded6sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-07 16:27:44 UTC

@codecovCodecov
Copy link

codecovbot commentedJun 30, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base(d1388fc) to head(a299f95).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11357   +/-   ##=======================================  Coverage   90.85%   90.85%           =======================================  Files         501      501             Lines       50978    50987    +9       Branches     8407     8410    +3     =======================================+ Hits        46315    46324    +9  Misses       4648     4648             Partials       15       15
FlagCoverage Δ
unittest90.85% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-eslint/src/config-helper.ts100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewJune 30, 2025 16:39
@kirkwaiblingerkirkwaiblinger requested a review froma teamJune 30, 2025 21:26
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesJun 30, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

⚡

kirkwaiblinger reacted with heart emoji
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJun 30, 2025
bradzacher
bradzacher previously approved these changesJun 30, 2025
@@ -23,6 +23,11 @@ export type InfiniteDepthConfigWithExtends =
| InfiniteDepthConfigWithExtends[];

export interface ConfigWithExtends extends TSESLint.FlatConfig.Config {
/**
* The base path for files and ignores.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe add a@since eslint v9.x.y?

kirkwaiblinger and JoshuaKGoldberg reacted with thumbs up emoji
@github-actionsgithub-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJun 30, 2025
bradzacher
bradzacher previously approved these changesJul 1, 2025
@kirkwaiblinger
Copy link
MemberAuthor

@ntnyq coming from#11363 (comment) can you give an explanation ofwhy that change should be made? I'm not following.

@kirkwaiblinger
Copy link
MemberAuthor

Thought about it and@ntnyq was right - thebasePath property needs to be on theConfig type, not theConfigWithExtends type. Added a commit and co-author attribution

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good :)

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJul 7, 2025
@kirkwaiblingerkirkwaiblingerenabled auto-merge (squash)July 7, 2025 16:15
@kirkwaiblingerkirkwaiblinger merged commit0c40c7a intotypescript-eslint:mainJul 7, 2025
59 of 61 checks passed
@kirkwaiblingerkirkwaiblinger deleted the support-base-path branchJuly 7, 2025 23:47
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: SupportbasePath property inConfig of ESLint
3 participants
@kirkwaiblinger@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp