chore(rule-tester): correct typo in test#11338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kirkwaiblinger merged 2 commits intotypescript-eslint:mainfromcseas:test-RuleTester-null

Jun 24, 2025

Merged

chore(rule-tester): correct typo in test#11338

kirkwaiblinger merged 2 commits intotypescript-eslint:mainfromcseas:test-RuleTester-null

Jun 24, 2025

+1 −0

Conversation

Copy link

Contributor

cseas commentedJun 24, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesRepo: duplicated test cases inRuleTester.test.ts #11285
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Modified the test as suggested in#11285 (comment)

test: correct null output test in RuleTester

306daac

Copy link

Contributor

typescript-eslintbot commentedJun 24, 2025

Thanks for the PR,@cseas!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJun 24, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`7bc1a91`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/685b20a5557eba000898570b
😎 Deploy Preview	https://deploy-preview-11338--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 91 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedJun 24, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit7bc1a91.

Command	Status	Duration	Result
`nx run-many -t typecheck`	✅ Succeeded	1m 54s	View ↗
`nx run-many -t lint`	✅ Succeeded	11s	View ↗
`nx run integration-tests:test`	✅ Succeeded	<1s	View ↗
`nx run types:build`	✅ Succeeded	<1s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	<1s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	<1s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	<1s	View ↗
`nx run generate-configs`	✅ Succeeded	4s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗