Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: mention ESLint's defineConfig()#11335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JoshuaKGoldberg wants to merge2 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromJoshuaKGoldberg:mention-define-config

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds an aside underQuickstart explaining the transientdefineConfig() situation, along with a similar note under thetypescript-eslint package docs.

I experimented for a bit splitting existingtseslint.config code blocks into tabs as suggested by the issue. That felt more confusing to me: that it was almost suggesting writing to files. Explaining the difference would have taken up even more previous docs space.

💖

@JoshuaKGoldbergJoshuaKGoldberg requested review fromnzakas anda teamJune 23, 2025 17:31
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 23, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit876eaf0
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6859b33b5a69940008b3976a
😎 Deploy Previewhttps://deploy-preview-11335--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 23, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit876eaf0.

CommandStatusDurationResult
nx run-many -t typecheck✅ Succeeded1m 58sView ↗
nx run-many -t lint✅ Succeeded10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded1sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded5sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-23 20:09:44 UTC

@codecovCodecov
Copy link

codecovbot commentedJun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base(2e35e3a) to head(6c3b8a3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11335   +/-   ##=======================================  Coverage   90.84%   90.84%           =======================================  Files         501      501             Lines       50911    50919    +8       Branches     8383     8386    +3     =======================================+ Hits        46248    46256    +8  Misses       4648     4648             Partials       15       15
FlagCoverage Δ
unittest90.84% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kirkwaiblinger
kirkwaiblinger previously approved these changesJun 23, 2025
:::note
ESLint also provides a `defineConfig()` helper similar to `tseslint.config`.
However, there is an types incompatibility issue that causes type errors to incorrectly be reported when mixing typescript-eslint's configs and `defineConfig()`.
For now we recommend using `tseslint.config` for type-safe configs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mention issue number here too?

JoshuaKGoldberg reacted with thumbs up emoji
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJun 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@nzakasnzakasAwaiting requested review from nzakas

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Mention ESLint'sdefineConfig (untiltseslint.config is deprecated)
2 participants
@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp