Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin-internal): [no-dynamic-tests] new internal Lint rule to ban dynamic syntax in generating tests#11323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
nayounsang wants to merge4 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromnayounsang:dynamic-lint

Conversation

nayounsang
Copy link
Contributor

@nayounsangnayounsang commentedJun 20, 2025•
edited
Loading

PR Checklist

Overview

no-dynamic-tests

Ban these:

  1. spread
  2. function
  3. conditional
  4. op

And add test cases for this feature
At this point, it seems too early to apply this rule directly to packages, so I'll just implement the logic.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 20, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5a2d020
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68555e15b6bd620008e1242f
😎 Deploy Previewhttps://deploy-preview-11323--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 20, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit5a2d020.

CommandStatusDurationResult
nx run-many -t typecheck✅ Succeeded1m 50sView ↗
nx run-many -t lint✅ Succeeded10sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded7sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded<1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded1sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded4sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-20 13:21:31 UTC

@nayounsangnayounsang changed the titlefeat(eslint-plugin-internal) : Lint rule to ban dynamic syntax in generating testsfeat(eslint-plugin-internal): Lint rule to ban dynamic syntax in generating testsJun 20, 2025
@codecovCodecov
Copy link

codecovbot commentedJun 20, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base(76cc62c) to head(5a2d020).

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11323      +/-   ##==========================================+ Coverage   90.84%   90.85%   +0.01%==========================================  Files         501      502       +1       Lines       50911    50997      +86       Branches     8383     8408      +25     ==========================================+ Hits        46248    46334      +86  Misses       4648     4648                Partials       15       15
FlagCoverage Δ
unittest90.85% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...lint-plugin-internal/src/rules/no-dynamic-tests.ts100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nayounsangnayounsang changed the titlefeat(eslint-plugin-internal): Lint rule to ban dynamic syntax in generating testsfeat(eslint-plugin-internal): [no-dynamic-tests] new internal Lint rule to ban dynamic syntax in generating testsJun 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Lint rule to ban dynamic syntax in generating tests
1 participant
@nayounsang
[8]ページ先頭
©2009-2025 Movatter.jp