Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-unused-vars] nois assigned a value but only used as a type error when it has a same name#11322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
nayounsang wants to merge4 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromnayounsang:type-unused

Conversation

nayounsang
Copy link
Contributor

@nayounsangnayounsang commentedJun 20, 2025•
edited
Loading

PR Checklist

Overview

Strict checks on exports with same type and variable name

  • If the name is the same, the variable isisTypeVariable && isValueVariable.
  • ClassName,TSEnumName,TSModuleName,ImportBinding andarguments also have same characteristics
  • Therefore, only the cases that correspond to the issue are properly verified.

Perform additional validating for abnormal cases

  • def.node.type !== AST_NODE_TYPES.TSTypeAliasDeclaration

Add test cases

  • tc mentioned in issue and similar but valid

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 20, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2f474b3
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6855574bb5b6cb000850e215
😎 Deploy Previewhttps://deploy-preview-11322--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nayounsangnayounsang changed the titlefix(eslint-plugin): [no-unused-vars] nois assigned a value but only used as a type error when it has a same name type alias declaration exportefix(eslint-plugin): [no-unused-vars] nois assigned a value but only used as a type error when it has a same nameJun 20, 2025
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 20, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit2f474b3.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 1sView ↗
nx run-many -t typecheck✅ Succeeded2m 6sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run-many -t lint✅ Succeeded10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded4sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-20 12:53:10 UTC

@codecovCodecov
Copy link

codecovbot commentedJun 20, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is88.00000% with3 lines in your changes missing coverage. Please review.

Project coverage is 90.84%. Comparing base(76cc62c) to head(2f474b3).

Files with missing linesPatch %Lines
...s/eslint-plugin/src/util/collectUnusedVariables.ts88.00%3 Missing⚠️

❌ Your patch check has failed because the patch coverage (88.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11322   +/-   ##=======================================  Coverage   90.84%   90.84%           =======================================  Files         501      501             Lines       50911    50932   +21       Branches     8383     8391    +8     =======================================+ Hits        46248    46269   +21  Misses       4648     4648             Partials       15       15
FlagCoverage Δ
unittest90.84% <88.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...s/eslint-plugin/src/util/collectUnusedVariables.ts96.34% <88.00%> (+0.15%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

functionisSafeUnusedExportCondition(variable:ScopeVariable):boolean{
if(variableinstanceofESLintScopeVariable){
returntrue;
}
Copy link
ContributorAuthor

@nayounsangnayounsangJun 20, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

need advice

I don't know why this condition is necessary. Can't the arg type ofisExported,isMergableExported be used asVariable?
Actually, it is used asVariable only.

@@ -465,7 +495,12 @@ function isExported(variable: ScopeVariable): boolean {
}

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
returnnode.parent!.type.startsWith('Export');
constisExportedFlag=node.parent!.type.startsWith('Export');
Copy link
ContributorAuthor

@nayounsangnayounsangJun 20, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

need advice

Is there a reason why didn't use optional chaining before?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unused-vars] nois assigned a value but only used as a type error when it has a same name type alias declaration exported
1 participant
@nayounsang
[8]ページ先頭
©2009-2025 Movatter.jp