typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(types): add 2026/17 to EcmaVersion#11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intotypescript-eslint:mainfromDavidArchibald:ecmaVersion2026

Jun 13, 2025

Merged

fix(types): add 2026/17 to EcmaVersion#11304

bradzacher merged 1 commit intotypescript-eslint:mainfromDavidArchibald:ecmaVersion2026

Jun 13, 2025

+2 −0

Conversation

Copy link

Contributor

DavidArchibald commentedJun 13, 2025•
edited by bradzacher
Loading

PR Checklist

Addresses an existing open issue: fixesBug: Type '17' is not assignable to type 'EcmaVersion' #11305
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

I didn't open an issue because it's just for updating a single type for 2026.

I was happening to be manually updating my dependencies and was very confused when I suddenly started getting this error:

Argumentoftype 'Config<RulesRecord>' is not assignable to parameter of type 'InfiniteDepthConfigWithExtends'.Type'Config<RulesRecord>'isnotassignabletotype'ConfigWithExtends'.Typesofproperty'languageOptions'areincompatible.Type'import("/home/david/Projects/My Price Health/mono/node_modules/eslint/lib/types/index").Linter.LanguageOptions | undefined'isnotassignabletotype'import("/home/david/Projects/My Price Health/mono/node_modules/@typescript-eslint/utils/dist/ts-eslint/Config").FlatConfig.LanguageOptions | undefined'.Type 'import("/home/david/Projects/My Price Health/mono/node_modules/eslint/lib/types/index").Linter.LanguageOptions' is not assignable to type 'import("/home/david/Projects/My Price Health/mono/node_modules/@typescript-eslint/utils/dist/ts-eslint/Config").FlatConfig.LanguageOptions'.Typesofproperty 'ecmaVersion'areincompatible.Type'EcmaVersion | undefined'isnotassignabletotype'EcmaVersion'.Type'17'isnotassignabletotype'EcmaVersion'.

This happened because I was writing this:

exportdefaultts.config([...],    ...compat.extends("old-config")[...]);

Playground
_{Note to future readers: if you enter this playground after this PR has been merged the error will have been fixed because I don't know how to pin dependency version in the TypeScript playground}

And due tocompat.extends simply returningConfig<RulesRecord>, the update inv9.29.0 to add support for 2026 broke this.

I also considered switching form manually definingexport type EcmaVersion = ... independently to beingexport type EcmaVersion = eslint.Linter.EcmaVersion; as that'd solve the issue in the future but I figured there must be a reason for manually definingEcmaVersion. Perhaps peer dependency issues?

Copy link

Contributor

typescript-eslintbot commentedJun 13, 2025

Thanks for the PR,@DavidArchibald!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJun 13, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f6411ab`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/684c875fb0b02f0008e357ed
😎 Deploy Preview	https://deploy-preview-11304--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 64 (🔴 down 35 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

fix: add 2026/17 to EcmaVersion

f6411ab

DavidArchibald force-pushed theecmaVersion2026 branch from6143b90 tof6411abCompare

June 13, 2025 20:17

Copy link

nx-cloudbot commentedJun 13, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf6411ab.

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 5s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 58s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	19s	View ↗
`nx run-many -t lint`	✅ Succeeded	13s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	7s	View ↗
`nx run generate-configs`	✅ Succeeded	10s	View ↗
`nx run integration-tests:test`	✅ Succeeded	<1s	View ↗
`nx run types:build`	✅ Succeeded	1s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗