Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(rule-tester):context.cwd
should always beprocess.cwd
in rule tester#11302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Thanks for the PR,@JounQin! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedJun 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
context.cwd
should always beprocess.cwd
in rule testercontext.cwd
should always beprocess.cwd
in rule testernx-cloudbot commentedJun 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commit287dd32.
☁️Nx Cloud last updated this comment at |
I didn't know about that PR at all. @reduckted Do you have any idea here? |
I've been working on this too, but I can't seem to come up with a good way to test it. |
JounQin commentedJun 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks@nayounsang. Maybe I should just close this PR? I don't have enough bandwidth to investigate deeply. I was thinking it's easy to fix. |
Oh, no problem. I'll leave it up to you to decide. It seems simple to fix the problem itself (you've already done a lot of work). |
PR Checklist
context.cwd
is incorrect set as/
when absolute path is used asfilename
in rule tester #11274Overview
According toeslint/eslint#19821 (comment)