Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(rule-tester):context.cwd should always beprocess.cwd in rule tester#11302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
JounQin wants to merge1 commit intotypescript-eslint:mainfromJounQin:patch-1

Conversation

JounQin
Copy link
Contributor

PR Checklist

Overview

According toeslint/eslint#19821 (comment)

context.cwd should, I believe, always beprocess.cwd() when rules are run through RuleTester.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JounQin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 13, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit287dd32
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/684c1dc2237d420008faa838
😎 Deploy Previewhttps://deploy-preview-11302--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@JounQinJounQin changed the titlefix:context.cwd should always beprocess.cwd in rule testerfix(rule-tester):context.cwd should always beprocess.cwd in rule testerJun 13, 2025
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 13, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit287dd32.

CommandStatusDurationResult
nx test eslint-plugin-internal --coverage=false❌ Failed6sView ↗
nx run eslint-plugin-internal:test -- --coverage❌ Failed8sView ↗
nx test eslint-plugin-internal❌ Failed6sView ↗
nx run-many -t typecheck✅ Succeeded1m 57sView ↗
nx run-many -t lint✅ Succeeded11sView ↗
nx run types:build✅ Succeeded1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded4sView ↗
Additional runs (7)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-13 12:51:05 UTC

@kirkwaiblinger
Copy link
Member

Hey@JounQin! Switching this to a draft since this isn't ready for review (failing existing tests, lack of added tests). Feel free to undraft when ready!

Btw, in case it's helpful,#10201 likely has important context for when you're working on this (you may already be aware of that)

JounQin reacted with thumbs up emoji

@kirkwaiblingerkirkwaiblinger marked this pull request as draftJune 13, 2025 14:13
@JounQin
Copy link
ContributorAuthor

Btw, in case it's helpful,#10201 likely has important context for when you're working on this (you may already be aware of that)

I didn't know about that PR at all.

@reduckted Do you have any idea here?

kirkwaiblinger reacted with thumbs up emoji

@nayounsang
Copy link
Contributor

I've been working on this too, but I can't seem to come up with a good way to test it.
After initializing the mocking withrestoreAllMocks(), access#lintersByBasePath and test with key. Its key is set to/ if input is absolutePath.
However, structurally, that field is inaccessible.

@JounQin
Copy link
ContributorAuthor

JounQin commentedJun 14, 2025
edited
Loading

I've been working on this too

Thanks@nayounsang. Maybe I should just close this PR? I don't have enough bandwidth to investigate deeply. I was thinking it's easy to fix.

@nayounsang
Copy link
Contributor

Oh, no problem. I'll leave it up to you to decide. It seems simple to fix the problem itself (you've already done a lot of work).
I was just mentioning the difficulty with the test code.
I have free time, so if you have any difficulties, please let me know anytime. I will continue working on it.

JounQin reacted with thumbs up emoji

@JounQinJounQin deleted the patch-1 branchJune 14, 2025 07:54
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug:context.cwd is incorrect set as/ when absolute path is used asfilename in rule tester
3 participants
@JounQin@kirkwaiblinger@nayounsang

[8]ページ先頭

©2009-2025 Movatter.jp