Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(eslint-plugin): switch auto-generated test cases to hand-written in no-inferrable-types.test.ts#11275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Vinccool96 wants to merge2 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromVinccool96:chore/11044-no-inferable-types-hand-written

Conversation

Vinccool96
Copy link
Contributor

PR Checklist

Overview

  • Change dynamic test cases using spread and map to hand-written ones
  • Specify existing recurring cases through comments

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 5, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf2133e7
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6841fb1018c8b4000804858a
😎 Deploy Previewhttps://deploy-preview-11275--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 5, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf2133e7.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 7sView ↗
nx run-many -t typecheck✅ Succeeded1m 55sView ↗
nx run-many -t lint✅ Succeeded11sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded4sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-05 20:26:44 UTC

"const a = new RegExp('a');",
// Testing with double quotes
// eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting
'const a = "str";',
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could be removed, since the only change with the one below is that it's using double quotes

{
// Testing with double quotes
// eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting
code: 'const a: string = "str";',
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could be removed, since the only change with the one below is that it's using double quotes

@Vinccool96Vinccool96 marked this pull request as ready for reviewJune 5, 2025 17:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: [no-inferrable-types.test.ts] Switch auto-generated test cases to hand-written
1 participant
@Vinccool96
[8]ページ先頭
©2009-2025 Movatter.jp