Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): add validation to interface extends#11271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ntdiary
Copy link
Contributor

@ntdiaryntdiary commentedJun 5, 2025•
edited
Loading

PR Checklist

Overview

The validation logic comes fromTypeScript.isPropertyAccessEntityNameExpression andisEntityNameExpression are internal functions fromTypeScript, I’ve temporarily placed them above theConverter class, not sure if that’s the good place for them. :)

These are some cases that will throw errors:

// ParenthesizedExpressioninterfaceAextends(typeoffs){}// ElementAccessExpressioninterfaceBextendsC['D']{}// OptionalChaininterfaceEextendsF?.G{}// multiple extendsinterfaceHextendsIextendsJ{}// NumericLiteralinterfaceKextends2{}// nested CallExpressioninterfaceLextendsM().N{}

💖

fisker reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 5, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit98625ef
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/684689c3cb88bb000821e3da
😎 Deploy Previewhttps://deploy-preview-11271--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 93 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 5, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit98625ef.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 3sView ↗
nx run-many -t typecheck✅ Succeeded1m 57sView ↗
nx test typescript-estree --coverage=false✅ Succeeded18sView ↗
nx run types:build✅ Succeeded1sView ↗
nx run-many -t lint✅ Succeeded11sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded7sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded9sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-09 07:26:27 UTC

@codecovCodecov
Copy link

codecovbot commentedJun 5, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is0% with29 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base(d159a21) to head(98625ef).
Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
packages/typescript-estree/src/convert.ts0.00%29 Missing⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11271      +/-   ##==========================================- Coverage   90.91%   90.85%   -0.06%==========================================  Files         501      501                Lines       50872    50901      +29       Branches     8383     8383              ==========================================  Hits        46248    46248- Misses       4609     4638      +29  Partials       15       15
FlagCoverage Δ
unittest90.85% <0.00%> (-0.06%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-estree/src/convert.ts30.37% <0.00%> (-0.29%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntdiaryntdiary marked this pull request as ready for reviewJune 5, 2025 12:23
bradzacher
bradzacher previously approved these changesJun 9, 2025
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for this!

ntdiary reacted with heart emoji
@bradzacherbradzacherenabled auto-merge (squash)June 9, 2025 07:14
@bradzacherbradzacherdisabled auto-mergeJune 9, 2025 07:21
@bradzacherbradzacherenabled auto-merge (squash)June 9, 2025 07:21
@bradzacherbradzacher merged commit685e530 intotypescript-eslint:mainJun 9, 2025
61 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestJun 14, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.32.1 | 8.34.0 || npm        | @typescript-eslint/parser        | 8.32.1 | 8.34.0 |## [v8.34.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8340-2025-06-09)##### 🩹 Fixes-   **typescript-estree:** add validation to interface extends ([#11271](typescript-eslint/typescript-eslint#11271))##### ❤️ Thank You-   TaoYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.33.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8331-2025-06-02)##### 🩹 Fixes-   exclude docs/ directory from eslint-plugin package ([#11251](typescript-eslint/typescript-eslint#11251))##### ❤️ Thank You-   roottoolYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.33.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8330-2025-05-26)This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestJun 14, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.32.1 | 8.34.0 || npm        | @typescript-eslint/parser        | 8.32.1 | 8.34.0 |## [v8.34.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8340-2025-06-09)##### 🩹 Fixes-   **typescript-estree:** add validation to interface extends ([#11271](typescript-eslint/typescript-eslint#11271))##### ❤️ Thank You-   TaoYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.33.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8331-2025-06-02)##### 🩹 Fixes-   exclude docs/ directory from eslint-plugin package ([#11251](typescript-eslint/typescript-eslint#11251))##### ❤️ Thank You-   roottoolYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.33.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8330-2025-05-26)This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Forbid invalidextend ininterface
2 participants
@ntdiary@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp