This PR tackles#1804 and adjusts the rule to report on invalid (non-promise) input passed to promise aggregator methods (Promise.all,Promise.race,Promise.allSettled, andPromise.any):

declareconstx:number[];// Unexpected iterator of non-Promise (non-"Thenable") values passed to promise aggregator.Promise.all(x);

ronami added2 commits

June 2, 2025 00:37

initial implementation

4bd647c

add promise.any

20ff75d

Copy link

Contributor

typescript-eslintbot commentedJun 1, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJun 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`81aead1`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68c066c6a0956f0007c0531e
😎 Deploy Preview	https://deploy-preview-11267--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 12 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedJun 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit81aead1

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 24s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗

☁️Nx Cloud last updated this comment at2025-09-09 18:02:20 UTC

ronami changed the title~~feat(await-thenable): report invalid (non-promise) values passed to promise aggregator methods~~feat(eslint-plugin): [await-thenable] report invalid (non-promise) values passed to promise aggregator methods

Jun 1, 2025

Copy link

codecovbot commentedJun 1, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is97.65625% with3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.92%. Comparing base (ef9173c) to head (81aead1).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/eslint-plugin/src/rules/await-thenable.ts	97.05%	3 Missing⚠️

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11267      +/-   ##==========================================+ Coverage   90.90%   90.92%   +0.01%==========================================  Files         505      506       +1       Lines       51208    51336     +128       Branches     8441     8469      +28     ==========================================+ Hits        46551    46676     +125- Misses       4644     4647       +3  Partials       13       13

Flag	Coverage Δ
unittest	`90.92% <97.65%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...slint-plugin/src/util/isPromiseAggregatorMethod.ts	`100.00% <100.00%> (ø)`
packages/eslint-plugin/src/rules/await-thenable.ts	`98.76% <97.05%> (-1.24%)`	⬇️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

libre-man commentedJun 6, 2025

It would be great if a test case for forPromise.all(x) wherex isArray<Array<Promise<T>> could be added, as this the bug that we recently had in#11257.

ronami added6 commits

June 24, 2025 23:16

add missing test

921942e

wip

e5bffbf

Merge remote-tracking branch 'origin/main' into promise-all-race-settled

62a6eed

refactor, fix edge cases

d46056a

add nested array test-case

ad08eb1

missing coverage

bcf18dc

ronami marked this pull request as ready for review

June 24, 2025 21:04

JoshuaKGoldberg previously approved these changes

Jun 30, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Jun 30, 2025

kirkwaiblinger reviewed

Jul 3, 2025

View reviewed changes

packages/eslint-plugin/src/rules/await-thenable.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/await-thenable.ts Outdated

		if(tsutils.isTypeReference(part)){
		consttypeArguments=checker.getTypeArguments(part);

		// only check the first type argument of `Iterator<...>` or `Array<...>`

Copy link

Member

kirkwaiblingerJul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The heuristics here seem to have minor edge case bugs.

interfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfNull:MyArray<Promise<void>,null>;declareconstarrayOfPromises:MyArray<null,Promise<void>>;Promise.all(arrayOfNull);// no report; should reportPromise.all(arrayOfPromises);// does report; shouldn't report

Note that if you switchinterface totype, this works correctly 🧐

Copy link

MemberAuthor

ronamiJul 21, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Interesting! I didn't consider this edge case!

I took some time trying to figure this out, here are my thoughts:

checker.isArrayType() doesn't flag this type as array, and I've only managed to compare this kind of value is withchecker.isArrayLikeType() (which seems to check if the value is assignable toArray<any>).
Getting the type of the element(s) of the array seems to be a bit trickier, and may be possible through TypeScript's internalgetIterationTypesOfIterable or similar.
Unless additional APIs are exposed, the best I've managed to come up with is usingchecker.isArrayLikeType() and getting the value of the array viaarrayType.getNumberIndexType(). This seems to work OK, though a similar case that extendsIterable still has this issue (playground link):
```
interfaceMyIterable<Unused,T>extendsIterable<T>{}declareconstx:MyIterable<Promise<void>,null>;// should report but doesn'tPromise.all(x);
```

This issue seems to affect additional rules, I was able to create these reproducible ones (should I open issues for them? I'm not sure how often this case gets used in the wild):

no-base-to-string (link to playground):

// normally reports correctlydeclareconstx:Array<object>;`${x}`;// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfObjects:MyArray<null,object>;`${arrayOfObjects}`;

no-floating-promises (link to playground):

// normally reports correctlydeclareconstx:Array<Promise<void>>;x;// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfPromises:MyArray<null,Promise<void>>;arrayOfPromises;

prefer-reduce-type-parameter (link to playground):

// normally reports correctlydeclareconstx:Array<string>x.reduce((accum,name)=>({    ...accum,[name]:true,}),{}asRecord<string,boolean>,);// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfStrings:MyArray<null,string>;arrayOfStrings.reduce((accum,name)=>({    ...accum,[name]:true,}),{}asRecord<string,boolean>,);

I updated the PR with the changes described above, would love to hear your thoughts.

Edit: I think themain branch has failing tests which cause this PR to be red too.

Copy link

Member

kirkwaiblingerJul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! I'm going to be away from a computer until beginning of August. I can look at it then, or feel free to move this along in the meantime 🙂

Copy link

Member

kirkwaiblingerAug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I always appreciate how deeply you investigate things like this, and how clear the examples you come up with are 🙏

Interesting! I didn't consider this edge case!
I took some time trying to figure this out, here are my thoughts:
checker.isArrayType() doesn't flag this type as array, and I've only managed to compare this kind of value is withchecker.isArrayLikeType() (which seems to check if the value is assignable toArray<any>).
Getting the type of the element(s) of the array seems to be a bit trickier, and may be possible through TypeScript's internalgetIterationTypesOfIterable or similar.
Unless additional APIs are exposed, the best I've managed to come up with is usingchecker.isArrayLikeType() and getting the value of the array viaarrayType.getNumberIndexType(). This seems to work OK, though a similar case that extendsIterable still has this issue (playground link):
interfaceMyIterable<Unused,T>extendsIterable<T>{}declareconstx:MyIterable<Promise<void>,null>;// should report but doesn'tPromise.all(x);
This issue seems to affect additional rules, I was able to create these reproducible ones (should I open issues for them? I'm not sure how often this case gets used in the wild):
no-base-to-string (link to playground):
// normally reports correctlydeclareconstx:Array<object>;`${x}`;// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfObjects:MyArray<null,object>;`${arrayOfObjects}`;

I actually think this behavior is arguably correct here. It's only with a true built-in array that the.toString() behavior is known to subsequently call its elements'.toString()s, whereas other "array"s/arraylikes may have different stringification. So in this case, we're reasoning based on implementation details of built-in arrays.

no-floating-promises (link to playground):

// normally reports correctlydeclareconstx:Array<Promise<void>>;x;// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfPromises:MyArray<null,Promise<void>>;arrayOfPromises;

prefer-reduce-type-parameter (link to playground):

// normally reports correctlydeclareconstx:Array<string>x.reduce((accum,name)=>({    ...accum,[name]:true,}),{}asRecord<string,boolean>,);// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfStrings:MyArray<null,string>;arrayOfStrings.reduce((accum,name)=>({    ...accum,[name]:true,}),{}asRecord<string,boolean>,);

With these two... It's debatable IMO, and I could be convinced either way what the "correct" behavior is. We're linting for how these arraylikes quack, rather than the exact implementation details. Though (maybe?) an argument maybe could be made that the signature of.reduce() is an implementation detail rather than a general feature of arraylikes.

In any case I don't think there's a clear cut wrong behavior in any of these that warrants proactively filing issues (versus reacting to user feedback if anyone encounters these edge cases in the wild).

I updated the PR with the changes described above, would love to hear your thoughts.

I think this current state looks great! I'd say this is a very good "best effort" approach at replicating thegetIterationTypesOfIterable TS API (which really would be nice to have!), and we'll find out from user feedback if the remaining edge cases really are necessary to solve. Thanks for digging so deep into this.

Edit: I think themain branch has failing tests which cause this PR to be red too.

Yep, should be fixed now! (after merging from main)

packages/eslint-plugin/src/rules/await-thenable.ts OutdatedShow resolvedHide resolved

kirkwaiblinger added the awaiting responseIssues waiting for a reply from the OP or another party label

Jul 6, 2025

JoshuaKGoldberg removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Jul 7, 2025

Update packages/eslint-plugin/src/rules/await-thenable.ts

a409343

Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com>

ronami dismissedJoshuaKGoldberg’sstale review viaa409343

July 21, 2025 18:23

ronami added2 commits

July 21, 2025 21:24

Merge branch 'main' into promise-all-race-settled

d7fb0b1

use checker.isArrayLikeType for checking types that extend an array

99343da

ronami requested a review fromkirkwaiblinger

July 21, 2025 19:32

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Jul 21, 2025

kirkwaiblinger mentioned this pull request

Jul 31, 2025

[await-thenable] warn against passing non-promise values to promise aggregators (Promise.all,Promise.allSettled,Promise.race)#1804

Closed

kirkwaiblinger requested changes

Aug 3, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Couple of small things, mostly around testing, but this otherwise looks great! Oh and one larger question around special-casing array literals.

packages/eslint-plugin/src/rules/await-thenable.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/await-thenable.test.tsShow resolvedHide resolved

packages/eslint-plugin/tests/rules/await-thenable.test.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/await-thenable.test.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/await-thenable.ts Outdated

		if(tsutils.isTypeReference(part)){
		consttypeArguments=checker.getTypeArguments(part);

		// only check the first type argument of `Iterator<...>` or `Array<...>`

Copy link

Member

kirkwaiblingerAug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I always appreciate how deeply you investigate things like this, and how clear the examples you come up with are 🙏

Interesting! I didn't consider this edge case!
I took some time trying to figure this out, here are my thoughts:
checker.isArrayType() doesn't flag this type as array, and I've only managed to compare this kind of value is withchecker.isArrayLikeType() (which seems to check if the value is assignable toArray<any>).
Getting the type of the element(s) of the array seems to be a bit trickier, and may be possible through TypeScript's internalgetIterationTypesOfIterable or similar.
Unless additional APIs are exposed, the best I've managed to come up with is usingchecker.isArrayLikeType() and getting the value of the array viaarrayType.getNumberIndexType(). This seems to work OK, though a similar case that extendsIterable still has this issue (playground link):
interfaceMyIterable<Unused,T>extendsIterable<T>{}declareconstx:MyIterable<Promise<void>,null>;// should report but doesn'tPromise.all(x);
This issue seems to affect additional rules, I was able to create these reproducible ones (should I open issues for them? I'm not sure how often this case gets used in the wild):
no-base-to-string (link to playground):
// normally reports correctlydeclareconstx:Array<object>;`${x}`;// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfObjects:MyArray<null,object>;`${arrayOfObjects}`;

no-floating-promises (link to playground):

// normally reports correctlydeclareconstx:Array<Promise<void>>;x;// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfPromises:MyArray<null,Promise<void>>;arrayOfPromises;

prefer-reduce-type-parameter (link to playground):

// normally reports correctlydeclareconstx:Array<string>x.reduce((accum,name)=>({    ...accum,[name]:true,}),{}asRecord<string,boolean>,);// should report but doesn'tinterfaceMyArray<Unused,T>extendsArray<T>{};declareconstarrayOfStrings:MyArray<null,string>;arrayOfStrings.reduce((accum,name)=>({    ...accum,[name]:true,}),{}asRecord<string,boolean>,);

I updated the PR with the changes described above, would love to hear your thoughts.

Edit: I think themain branch has failing tests which cause this PR to be red too.

Yep, should be fixed now! (after merging from main)

kirkwaiblinger added the awaiting responseIssues waiting for a reply from the OP or another party label

Aug 3, 2025

Merge remote-tracking branch 'origin/main' into promise-all-race-settled

0e1ac05

ronami added3 commits

September 8, 2025 20:44

code review comments

94cbf8c

special case array literals

67095b7

add ts-expect-error above tests with a type error

39551b1

Copy link

MemberAuthor

ronami commentedSep 8, 2025

Thanks@kirkwaiblinger! I'm really sorry for how long it took me to get back to this.

ronami requested a review fromkirkwaiblinger

September 8, 2025 18:48

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Sep 8, 2025

kirkwaiblinger approved these changes

Sep 9, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Another Ronen banger 🥳 ❤️

kirkwaiblinger previously approved these changes

Sep 9, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I had a look and a few of the missing cov lines are reachable for tests, but this is good with or without those tweaks 👍

packages/eslint-plugin/src/rules/await-thenable.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/await-thenable.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/await-thenable.ts

		returnchecker.getTypeArguments(type).slice(0,1);
		}

		returnnull;

Copy link

Member

kirkwaiblingerSep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(cov nit) this might also be unreachable? 🤷 But if soreturn null; seems correct as-is here rather than anullThrows() 👍

Copy link

MemberAuthor

ronamiSep 9, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, I completely missed codcov, thanks! I've updated the PR with your suggestions. I'm not sure about this one though, it's hard to tell if it's truly unreachable or if there's a case I've missed.

I think this is OK either way (though I think this would require throwinglike is done here instead ofnullThrows()).

update lines missing code coverage

81aead1

ronami dismissedkirkwaiblinger’sstale review via81aead1

September 9, 2025 17:41

kirkwaiblinger approved these changes

Sep 9, 2025

View reviewed changes

Copy link

Contributor

Zamiell commentedSep 12, 2025

Hey ronami! I've been wanting this bug to be fixed for many years now, so thanks for all your hard work on this!

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Sep 12, 2025

JoshuaKGoldberg approved these changes

Sep 15, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Absolutely lovely. The implementation is very readable and clear, but also handles a lot of edge cases well. Very nicely done.

One less 2020 issue to worry about!

🔥

JoshuaKGoldberg merged commit85d8dea intotypescript-eslint:main

Sep 15, 2025

166 of 171 checks passed

ronami deleted the promise-all-race-settled branch

September 15, 2025 12:22

abrahamguo mentioned this pull request

Sep 15, 2025

Bug: [await-thenable] inconsistent behavior on promise unions#11609

Closed

4 tasks

chrisbbreuer mentioned this pull request

Sep 15, 2025

chore(deps): update all non-major dependenciesstacksjs/eslint-plugin#54

Closed

ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull request

Sep 16, 2025

Porttypescript-eslint/typescript-eslint#11267as a patch

f9c5aec

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Sep 17, 2025

Update typescript-eslint monorepo to v8.44.0

181f7dd

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.43.0 | 8.44.0 || npm        | @typescript-eslint/parser        | 8.43.0 | 8.44.0 |## [v8.44.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15)##### 🚀 Features- **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#11267](typescript-eslint/typescript-eslint#11267))##### 🩹 Fixes- **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#11490](typescript-eslint/typescript-eslint#11490))##### ❤️ Thank You- Moses Odutusin [@thebolarin](https://github.com/thebolarin)- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Sep 17, 2025

Update typescript-eslint monorepo to v8.44.0

57fde0e

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.43.0 | 8.44.0 || npm        | @typescript-eslint/parser        | 8.43.0 | 8.44.0 |## [v8.44.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15)##### 🚀 Features- **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#11267](typescript-eslint/typescript-eslint#11267))##### 🩹 Fixes- **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#11490](typescript-eslint/typescript-eslint#11490))##### ❤️ Thank You- Moses Odutusin [@thebolarin](https://github.com/thebolarin)- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

chrisbbreuer mentioned this pull request

Sep 18, 2025

chore(deps): update all non-major dependenciesstacksjs/eslint-plugin#64

Closed

fossabotbot mentioned this pull request

Sep 29, 2025

Bump @typescript-eslint/eslint-plugin from 8.42.0 to 8.44.1fossas/fossa-action#210

Merged

chrisbbreuer mentioned this pull request

Oct 4, 2025

chore(deps): update all non-major dependenciesstacksjs/eslint-plugin#67

Open

1 task

fossabotbot mentioned this pull request

Oct 6, 2025

chore(deps-dev): bump the dependencies group with 4 updatesopenfga/js-sdk#263

Merged

kirkwaiblinger mentioned this pull request

Oct 11, 2025

Rule proposal: promise aggregator method checks#11694

Open

6 tasks

ch4og pushed a commit to csmplay/mapban that referenced this pull request

Nov 18, 2025

chore(deps): update typescript-eslint monorepo to v8.47.0 (#20)

0de7d9d

This PR contains the following updates:| Package | Change | Age | Confidence ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) || [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#&#8203;10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@&#8203;bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#&#8203;11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#&#8203;11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#&#8203;11006](typescript-eslint/typescript-eslint#11006), [#&#8203;10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@&#8203;undsoft](https://github.com/undsoft)- Kentaro Suzuki [@&#8203;sushichan044](https://github.com/sushichan044)- Maria Solano [@&#8203;MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#&#8203;11722](typescript-eslint/typescript-eslint#11722), [#&#8203;11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#&#8203;11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@&#8203;undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#&#8203;11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)##### 🩹 Fixes- **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#&#8203;11667](typescript-eslint/typescript-eslint#11667))- **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#&#8203;11533](typescript-eslint/typescript-eslint#11533))##### ❤️ Thank You- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)##### 🚀 Features- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#&#8203;11659](typescript-eslint/typescript-eslint#11659))- **rule-schema-to-typescript-types:** clean up and make public ([#&#8203;11633](typescript-eslint/typescript-eslint#11633))##### 🩹 Fixes- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#&#8203;11660](typescript-eslint/typescript-eslint#11660))- **typescript-estree:** forbid abstract method and accessor to have implementation ([#&#8203;11657](typescript-eslint/typescript-eslint#11657))- **eslint-plugin:** removed error type previously deprecated ([#&#8203;11674](typescript-eslint/typescript-eslint#11674))- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#&#8203;11603](typescript-eslint/typescript-eslint#11603))- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#&#8203;11634](typescript-eslint/typescript-eslint#11634))- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#&#8203;11628](typescript-eslint/typescript-eslint#11628))- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#&#8203;11487](typescript-eslint/typescript-eslint#11487))##### ❤️ Thank You- fisker Cheung [@&#8203;fisker](https://github.com/fisker)- Josh Goldberg ✨- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- Mark de Dios [@&#8203;peanutenthusiast](https://github.com/peanutenthusiast)- Richard Torres [@&#8203;richardtorres314](https://github.com/richardtorres314)- Victor Genaev [@&#8203;mainframev](https://github.com/mainframev)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#&#8203;11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#&#8203;11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#&#8203;11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@&#8203;thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@&#8203;y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#&#8203;11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#&#8203;11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#&#8203;11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)##### 🚀 Features- **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#&#8203;11267](typescript-eslint/typescript-eslint#11267))##### 🩹 Fixes- **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#&#8203;11490](typescript-eslint/typescript-eslint#11490))##### ❤️ Thank You- Moses Odutusin [@&#8203;thebolarin](https://github.com/thebolarin)- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#&#8203;11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#&#8203;11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#&#8203;11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#&#8203;11423](typescript-eslint/typescript-eslint#11423), [#&#8203;11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#&#8203;11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#&#8203;11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#&#8203;11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#&#8203;11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#&#8203;11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@&#8203;dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@&#8203;mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@&#8203;y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@&#8203;mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)##### 🩹 Fixes- **deps:** update eslint monorepo to v9.33.0 ([#&#8203;11482](typescript-eslint/typescript-eslint#11482))You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)##### 🩹 Fixes- **deps:** update dependency prettier to v3.6.2 ([#&#8203;11496](typescript-eslint/typescript-eslint#11496))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)##### 🚀 Features- **typescript-estree:** forbid invalid keys in `EnumMember` ([#&#8203;11232](typescript-eslint/typescript-eslint#11232))##### ❤️ Thank You- fisker Cheung [@&#8203;fisker](https://github.com/fisker)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4wIiwidXBkYXRlZEluVmVyIjoiNDIuMTAuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->Reviewed-on:https://git.in.csmpro.ru/csmpro/csm-mapban/pulls/20Co-authored-by: Renovate Bot <renovate@csmpro.ru>Co-committed-by: Renovate Bot <renovate@csmpro.ru>

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [await-thenable] report invalid (non-promise) values passed to promise aggregator methods#11267

feat(eslint-plugin): [await-thenable] report invalid (non-promise) values passed to promise aggregator methods#11267

Conversation

ronami commentedJun 1, 2025

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJun 1, 2025

Uh oh!

netlifybot commentedJun 1, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJun 1, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedJun 1, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

libre-man commentedJun 6, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kirkwaiblingerJul 3, 2025

Choose a reason for hiding this comment

Uh oh!

ronamiJul 21, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kirkwaiblingerJul 21, 2025

Choose a reason for hiding this comment

Uh oh!

kirkwaiblingerAug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirkwaiblingerAug 3, 2025

Choose a reason for hiding this comment

Uh oh!

ronami commentedSep 8, 2025

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirkwaiblingerSep 9, 2025

Choose a reason for hiding this comment

Uh oh!

ronamiSep 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zamiell commentedSep 12, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

netlifybot commentedJun 1, 2025•
edited
Loading

nx-cloudbot commentedJun 1, 2025•
edited
Loading

codecovbot commentedJun 1, 2025•
edited
Loading

ronamiJul 21, 2025•
edited
Loading

ronamiSep 9, 2025•
edited
Loading