Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(project-service): add missingtypescript peer dependency#11265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JounQin
Copy link
Contributor

@JounQinJounQin commentedJun 1, 2025•
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JounQin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJun 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0f78d4d
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/683c33e69f29af000820715c
😎 Deploy Previewhttps://deploy-preview-11265--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJun 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit0f78d4d.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded4m 56sView ↗
nx run-many -t typecheck✅ Succeeded1m 59sView ↗
nx test typescript-estree --coverage=false✅ Succeeded18sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded6sView ↗
nx run-many -t lint✅ Succeeded10sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded5sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-06-01 11:16:06 UTC

@bradzacherbradzacher changed the titlefix:typescript should be peer dependency ofproject-servicefix(project-service): add missingtypescript peer dependencyJun 1, 2025
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

brilliant - thanks for this

@bradzacherbradzacherenabled auto-merge (squash)June 1, 2025 11:08
@bradzacherbradzacher merged commit9d46857 intotypescript-eslint:mainJun 1, 2025
63 of 67 checks passed
@JounQinJounQin deleted the fix/typescript_peer branchJune 1, 2025 11:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug:typescript should be peer dependency ofproject-service
2 participants
@JounQin@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp