Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore: upgrade to Docusaurus 3.7#11262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@benmccann! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedMay 31, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedMay 31, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commit1ad48bd.
☁️Nx Cloud last updated this comment at |
| @@ -55,7 +55,7 @@ | |||
| "typescript": "*" | |||
| }, | |||
| "devDependencies": { | |||
| "@docusaurus/module-type-aliases": "^3.2.1", | |||
| "@docusaurus/module-type-aliases": "~3.7.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Almost everywhere else uses^. I think the two existing~s might have been unintentional. Is there a reason to go with~ here?
If it doesn't make a strong difference, I'd think we'd rather stick with^ for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The reason was because larger changes are needed to adopt 3.8. Ideally we'd just upgrade to 3.8, but I was having trouble with that given that I'm not a React developer. I don't know if those changes would be hard for someone familiar with Docusaurus and React, but they might be a bit beyond me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah gotcha, so this is to make sure we don't accidentally bump to a3.8 of something then? In that case if it makes it easier to not accidentally bump, that seems reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚀 Functionally it all looks good to me. Just checking in on the^/~?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(wrong lever)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 assuming we'd switch back to^ once 3.8 happens.
Yes, I was thinking we'd switch back to |
6a7424c intotypescript-eslint:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
Upgrades to Docusaurus 3.7. It would be nice to upgrade to Docusaurus 3.8, but I can't figure out how to do that with this repo's setup. See here for my attempt at that:#11260