Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin-internal): check formatting in suggestion output fields#11261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

azat-io
Copy link
Contributor

Fixes the@typescript-eslint/internal/plugin-test-formatting rule to also check formatting ofoutput fields withinerrors[].suggestions[] arrays in test cases.

PR Checklist

Overview

Previously, the rule only checkedcode field at the top level of test objects, but ignoredoutput fields inside suggestion objects. This led to inconsistent formatting in test files where suggestion outputs could contain improperly formatted code.

Before:

suggestions:[{messageId:'suggestNullish',output:"bad formatting here",// ❌ Not checked},]

After

suggestions:[{messageId:'suggestNullish',output:"properly formatted code",// ✅ Now checked and auto-fixed},]

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@azat-io!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 31, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitfa29ac1
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/683ab41da3e579000814a27a
😎 Deploy Previewhttps://deploy-preview-11261--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 31, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitfa29ac1.

CommandStatusDurationResult
nx test eslint-plugin-internal --coverage=false❌ Failed6sView ↗
nx run eslint-plugin-internal:test -- --coverage❌ Failed8sView ↗
nx run-many -t typecheck✅ Succeeded1m 53sView ↗
nx run-many -t lint✅ Succeeded13sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded<1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx run generate-configs✅ Succeeded7sView ↗
nx run types:build✅ Succeeded1sView ↗
Additional runs (11)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-05-31 07:51:38 UTC

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@azat-io
[8]ページ先頭
©2009-2025 Movatter.jp