Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): add a default-off option to autofix remove unused imports#11243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
nayounsang wants to merge3 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromnayounsang:auto-unused

Conversation

nayounsang
Copy link

PR Checklist

Overview

DRAFT

  • When add optionenableAutofixRemoval: { imports: true }, auto fix and remove unused import statement
  • Add test case in issue
  • More test cases are needed. First of all, since it is my first contribution, it is very difficult, so I will think about it after uploading the PR. I can check the comments quickly.
  • There may be something wrong with the comma handling. First, pass the test case.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 23, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit7fc5d69
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6831c313e2a5d600083d1c13
😎 Deploy Previewhttps://deploy-preview-11243--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nayounsangnayounsang marked this pull request as draftMay 23, 2025 15:53
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 23, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit7fc5d69.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 3sView ↗
nx run-many -t typecheck✅ Succeeded2m 8sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run-many -t lint✅ Succeeded9sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-05-24 13:13:28 UTC

@nayounsang
Copy link
Author

Wow, when adding a new feature, a follow-up development is needed. I'll work on it tomorrow.

@codecovCodecov
Copy link

codecovbot commentedMay 24, 2025

Codecov Report

Attention: Patch coverage is85.36585% with12 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base(4ad8a07) to head(7fc5d69).

Files with missing linesPatch %Lines
packages/eslint-plugin/src/rules/no-unused-vars.ts85.36%12 Missing⚠️

❌ Your patch check has failed because the patch coverage (85.36%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11243      +/-   ##==========================================- Coverage   90.91%   90.90%   -0.01%==========================================  Files         501      501                Lines       50869    50951      +82       Branches     8382     8403      +21     ==========================================+ Hits        46248    46318      +70- Misses       4606     4618      +12  Partials       15       15
FlagCoverage Δ
unittest90.90% <85.36%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/no-unused-vars.ts98.25% <85.36%> (-1.75%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -2946,39 +3062,6 @@ declare module 'foo' {
{
code: `
export import Bar = Something.Bar;
const foo: 1234;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is github doing the comparison wrong? I checked and there is no part that has been deleted. There is no reason to delete it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [no-unused-vars] add a default-off option to autofix remove unused imports
1 participant
@nayounsang
[8]ページ先頭
©2009-2025 Movatter.jp