Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fix issues introduced by updatednx configuration#11230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 21, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit612f34c
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6863a4c8b1e3ce000838c870
😎 Deploy Previewhttps://deploy-preview-11230--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 21, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit612f34c.

CommandStatusDurationResult
nx run-many -t typecheck✅ Succeeded2m 7sView ↗
nx run-many -t lint✅ Succeeded2m 4sView ↗
nx run integration-tests:test✅ Succeeded47sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded3sView ↗
nx test typescript-estree --coverage=false✅ Succeeded1sView ↗
nx run types:build✅ Succeeded1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded1sView ↗
nx run generate-configs✅ Succeeded4sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-01 09:10:51 UTC

@codecovCodecov
Copy link

codecovbot commentedMay 21, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base(f9bd7d8) to head(612f34c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11230   +/-   ##=======================================  Coverage   90.84%   90.84%           =======================================  Files         501      501             Lines       50919    50919             Branches     8387     8387           =======================================  Hits        46256    46256             Misses       4648     4648             Partials       15       15
FlagCoverage Δ
unittest90.84% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger
Copy link
Member

Hi@aryaemami59 Are you still working on this and/or is it ready for review?

@aryaemami59aryaemami59 marked this pull request as ready for reviewJune 24, 2025 14:58
JamesHenry
JamesHenry previously approved these changesJul 1, 2025
@aryaemami59aryaemami59force-pushed thechore/fix-nx-config-issues branch fromac57f06 to3a2efe0CompareJuly 1, 2025 08:27
@JamesHenry
Copy link
Member

@aryaemami59 I'm working on this

aryaemami59 reacted with thumbs up emoji

@JamesHenry
Copy link
Member

@aryaemami59 Please don't push anymore

@JamesHenryJamesHenry merged commite2ecca6 intotypescript-eslint:mainJul 1, 2025
65 checks passed
@aryaemami59aryaemami59 deleted the chore/fix-nx-config-issues branchJuly 1, 2025 09:37
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: address issues introduced by updatednx configuration
3 participants
@aryaemami59@kirkwaiblinger@JamesHenry
[8]ページ先頭
©2009-2025 Movatter.jp