Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove postinstall steps from CI to speed up prepare-install action#11219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kirkwaiblinger wants to merge3 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromkirkwaiblinger:ci-speedup

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblingerkirkwaiblinger commentedMay 14, 2025
edited
Loading

PR Checklist

Overview

Take all of the following with a grain of salt since this is not my area of expertise...

The postinstall script can take a while (locally, at least) since it builds the whole project from scratch. I'm not sure to what extent this is mitigated by nx caching in CI, but, locally, the difference betweenSKIP_POSTINSTALL=true yarn andyarn is 9 seconds vs 68 seconds... So I'd think that explains the 1 minute prepare-install time mentioned in#11205

For CI steps that need the tasks done byyarn build, nx's dependency graphshould still execute the required build steps, meaning that we'll mostly just be shifting running time out of the prepare-install step, and into the main CI job. So, likely not a huge overall speedup for those cases. However, for actions thatdon't have any upstream build dependencies, like semantic-breaking-changes-pr, I would expect this to be a significant speedup.

I'd be surprised if this didn't break anything if merged to main, tbh. Previously, many of the nx build dependencies weren't accurately declared, and, therefore, several commands depended on the "build everything" task built intoyarn install. Note that@aryaemami59 has made quite a few fixes in this area, though! So perhaps things will work.

Merging this would also introduce a downside that CI failures would be harder for community contributors to debug since they would generally not know to doSKIP_POSTINSTALL=true yarn && yarn my-failing-command to replicate the behavior in CI.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 14, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitea54215
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/682510ac494fe10008ed6450
😎 Deploy Previewhttps://deploy-preview-11219--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 14, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commitea54215.

CommandStatusDurationResult
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded4sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-05-16 12:04:52 UTC

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 💯yes!

IMO we should merge this ASAP and see what breaks. If I'm understanding the nx philosophy right then all of our scripts should know to run their dependencies first. In a perfect world I think that means we'd be able to eventuallydelete the postinstall script and have it all automagically inferred. 🔪

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 16, 2025
@JamesHenry
Copy link
Member

There were some confusing nx config changes just merged in#11135 which have caused conflicts with this one

@JamesHenry
Copy link
Member

I'll share my thoughts in a loom to try and bring everyone on the same page

kirkwaiblinger reacted with thumbs up emoji

@kirkwaiblinger
Copy link
MemberAuthor

In a perfect world I think that means we'd be able to eventuallydelete the postinstall script and have it all automagically inferred. 🔪

For now, the postinstall script also does a bit of devx setup, in that it installs husky git hooks. So we probably still want it for that? For this PR, I went withSKIP_POSTINSTALL=true instead ofSKIP_POSTINSTALL_BUILD=true (which I periodically use locally) because I figured we don't need husky git hooks in CI.

But yeah possibly the part after theSKIP_POSTINSTALL_BUILD condition maybe could go in the future?

@JamesHenry
Copy link
Member

The PR and loom are here:#11226

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@kirkwaiblinger@JamesHenry@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp