typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore: use TLA in ESM scripts rather than async main().catch()#11218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kirkwaiblinger merged 2 commits intotypescript-eslint:mainfromkirkwaiblinger:use-esm-tla

May 16, 2025

Merged

chore: use TLA in ESM scripts rather than async main().catch()#11218

kirkwaiblinger merged 2 commits intotypescript-eslint:mainfromkirkwaiblinger:use-esm-tla

May 16, 2025

Conversation

Copy link

Member

kirkwaiblinger commentedMay 14, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Be sure to use "hide whitespace"

use TLA in ESM scripts

338f86f

Copy link

Contributor

typescript-eslintbot commentedMay 14, 2025

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMay 14, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`069c83f`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6827665808be740008ec1e25
😎 Deploy Preview	https://deploy-preview-11218--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 84 (🔴 down 15 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedMay 14, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit069c83f.

Command	Status	Duration	Result
`nx test eslint-plugin`	✅ Succeeded	6m 7s	View ↗
`nx run eslint-plugin:test -- --coverage`	✅ Succeeded	6m 27s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 8s	View ↗
`nx test visitor-keys`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	1s	View ↗
`nx test type-utils`	✅ Succeeded	25s	View ↗
`nx typecheck ast-spec`	✅ Succeeded	2s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	5s	View ↗
`Additional runs (26)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-05-16 16:39:34 UTC

kirkwaiblinger commented

May 14, 2025

View reviewed changes

packages/eslint-plugin/tools/generate-breaking-changes.mts

		import { markdownTable } from 'markdown-table';

		async function main(): Promise<void> {
		const rulesImport = await import('../src/rules/index.js');

Copy link

MemberAuthor

kirkwaiblingerMay 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I also took the liberty of turning this into a static import since... it seems like we can just turn it into a static import and get better typing? But I can revert that if that's wrong.