Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[REFERENCE] Rule creator packages prototypes#11207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
JoshuaKGoldberg wants to merge3 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromJoshuaKGoldberg:rule-creator-packages-prototypes

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedMay 12, 2025•
edited
Loading

Reference point of comparison for#10383. The three individual commits starting this branch's history show splitting outparser-services,types-eslint, and thenrule-creator packages.

The immediate splitting ofparser-services out fromtypescript-estree would be a pretty huge breaking change. I don't think it's feasible as shown in this PR. My hunch is we'll have to instead re-export types somehow. Will comment in the issue.

For simplicity's sake, this reference only movessrc/ source files.

@JoshuaKGoldbergJoshuaKGoldberg added the DO NOT MERGEPRs which should not be merged yet labelMay 12, 2025
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 12, 2025•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commit90c32b3
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6822098f9d90500008c2e10b

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 12, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit90c32b3.

CommandStatusDurationResult
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded2sView ↗
nx run-many --target=clean✅ Succeeded11sView ↗

☁️Nx Cloud last updated this comment at2025-05-12 14:57:00 UTC

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGEPRs which should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp