Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(eslint-plugin): [typedef] deprecate the rule#11202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedMay 12, 2025
edited
Loading

PR Checklist

Overview

At long last! We haven't recommended this rule inyears. It's mostly been kept around as a legacy support point. But it's been less and less useful over the years.

Primarily a docs change + addition ofmeta.deprecated to the rule.

Moves the:::caution note to be the first added content in the rule's docs file, and adds a note to it that the rule is deprecated.

Note that this does include a behavioral change: the rule is no longer in theall configs. Perhttps://typescript-eslint.io/users/configs#all, the contents ofall arenot considered semver-stable. This is not a breaking change.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 12, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit98d3fdd
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6821fa84197bfb0008b6d4fc
😎 Deploy Previewhttps://deploy-preview-11202--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 12, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit98d3fdd.

CommandStatusDurationResult
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded5sView ↗
nx run-many --target=clean✅ Succeeded11sView ↗

☁️Nx Cloud last updated this comment at2025-05-14 12:39:57 UTC

@JoshuaKGoldbergJoshuaKGoldberg changed the titledocs(eslint-plugin) [typedef] deprecate the ruledocs(eslint-plugin): [typedef] deprecate the ruleMay 12, 2025
@codecovCodecov
Copy link

codecovbot commentedMay 12, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base(f8db925) to head(98d3fdd).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11202   +/-   ##=======================================  Coverage   90.92%   90.92%           =======================================  Files         499      499             Lines       50845    50847    +2       Branches     8384     8384           =======================================+ Hits        46231    46233    +2  Misses       4599     4599             Partials       15       15
FlagCoverage Δ
unittest90.92% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/configs/eslintrc/all.ts100.00% <ø> (ø)
packages/eslint-plugin/src/configs/flat/all.ts100.00% <ø> (ø)
packages/eslint-plugin/src/rules/typedef.ts99.64% <100.00%> (+<0.01%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewMay 12, 2025 14:25
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 14, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit387eeb5 intotypescript-eslint:mainMay 19, 2025
112 of 114 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Mark typedef as deprecated / feature frozen
3 participants
@JoshuaKGoldberg@bradzacher@kirkwaiblinger

[8]ページ先頭

©2009-2025 Movatter.jp