Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: add note aboutmax-semi-size to performance section#11200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
maschwenk wants to merge2 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
frommaschwenk:main

Conversation

maschwenk
Copy link

PR Checklist

Overview

This setting has improved the performance of typed linting of our biggest app (~2.5 million LoC) by a factor of 2x.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@maschwenk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 10, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit903cf3f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6821ec5c197bfb0008b0d014
😎 Deploy Previewhttps://deploy-preview-11200--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 10, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit903cf3f.

CommandStatusDurationResult
nx run-many --target=clean✅ Succeeded12sView ↗
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run-many --target=build --parallel --exclude...✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded2sView ↗

☁️Nx Cloud last updated this comment at2025-05-12 12:55:51 UTC

@maschwenkmaschwenk changed the titleAdd note aboutmax-semi-size to performance sectiondocs: Add note aboutmax-semi-size to performance sectionMay 11, 2025
@maschwenkmaschwenk changed the titledocs: Add note aboutmax-semi-size to performance sectiondocs: add note aboutmax-semi-size to performance sectionMay 11, 2025
@maschwenk
Copy link
Author

My reproduction case here really requires you have a disgustingly large app to repro, so unsure if there are ideas

JoshuaKGoldberg reacted with laugh emoji

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMay 12, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable to me, but I'd like to defer to@bradzacher as the tsc-at-scale 👑

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 12, 2025
@github-actionsgithub-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 12, 2025
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 12, 2025
@codecovCodecov
Copy link

codecovbot commentedMay 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base(e57126a) to head(903cf3f).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11200   +/-   ##=======================================  Coverage   90.91%   90.92%           =======================================  Files         499      499             Lines       50809    50845   +36       Branches     8369     8384   +15     =======================================+ Hits        46195    46231   +36  Misses       4599     4599             Partials       15       15
FlagCoverage Δ
unittest90.92% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@bradzacherbradzacherAwaiting requested review from bradzacher

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@maschwenk@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp