Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore: convert some requires to import statements#112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This doesn't turn it on everywhere as doing so made some of the tests to fail.
JamesHenry commentedJan 21, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for looking to contribute,@aboyton! I'm afraid I don't understand the goal of this PR, and it is fundamentally broken. You are adding imports and exports to node .js files, that will not work. Also These are not changes we can make right now but thanks again for supporting the project |
All good. I was looking for an easy thing to get started on the project again and noticed that#67 had a comment
and so I figured I'd try see if I could turn some of them on. I wasn't sure if this would break anything or not, I ran the tests and then figured why not see if this was correct or useful. Sorry to waste your time. |
JamesHenry commentedJan 22, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Oh not at all, I really appreciate the offer of help! I'm afraid the new setup is just a little too new for us to have figured out good contributing guidance etc. We'll definitely improve on that and hopefully we'll see some more PRs from you in the near future :) |
armano2 commentedJan 22, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
idea of turning off @aboyton you can try updating it in ts files only and turning this rule off for all js files |
This doesn't turn it on everywhere as doing so made some of the tests to fail.