Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: convert some requires to import statements#112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

aboyton
Copy link
Contributor

This doesn't turn it on everywhere as doing so made some of the tests to fail.

This doesn't turn it on everywhere as doing so made some of the tests to fail.
@JamesHenry
Copy link
Member

JamesHenry commentedJan 21, 2019
edited
Loading

Thanks for looking to contribute,@aboyton! I'm afraid I don't understand the goal of this PR, and it is fundamentally broken. You are adding imports and exports to node .js files, that will not work. Also"resolveJsonModule": true will alter the structure of the build output, so has significant repercussions.

These are not changes we can make right now but thanks again for supporting the project

@aboyton
Copy link
ContributorAuthor

All good. I was looking for an easy thing to get started on the project again and noticed that#67 had a comment

i had to disable some of recommended rules, and we should fix issues reported by them.

and so I figured I'd try see if I could turn some of them on. I wasn't sure if this would break anything or not, I ran the tests and then figured why not see if this was correct or useful. Sorry to waste your time.

armano2 reacted with thumbs up emoji

@aboytonaboyton deleted the require-to-import branchJanuary 22, 2019 00:05
@JamesHenry
Copy link
Member

JamesHenry commentedJan 22, 2019
edited
Loading

Oh not at all, I really appreciate the offer of help! I'm afraid the new setup is just a little too new for us to have figured out good contributing guidance etc.

We'll definitely improve on that and hopefully we'll see some more PRs from you in the near future :)

aboyton reacted with thumbs up emoji

@armano2
Copy link
Collaborator

armano2 commentedJan 22, 2019
edited
Loading

idea of turning off@typescript-eslint/no-var-requires in js only files seems valid

@aboyton you can try updating it in ts files only and turning this rule off for all js files

j-f1 reacted with thumbs up emoji

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aboyton@JamesHenry@armano2

[8]ページ先頭

©2009-2025 Movatter.jp