Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(typescript-eslint): correct naming of import of typescript-eslint in test#11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Just a quick rename. The test code is a little confusing because it refers toplugin.configs, but we canonically would refer to this astseslint.configs, and it isnot equal totseslint.plugin.configs.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 8, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit90ac2e4
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/681d00822b047800080ad917
😎 Deploy Previewhttps://deploy-preview-11193--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@kirkwaiblingerkirkwaiblinger changed the titlechore(typescript-eslint): rename import of typescript-eslintchore(typescript-eslint): rename import of typescript-eslint in testMay 8, 2025
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 8, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit90ac2e4.

CommandStatusDurationResult
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded2sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-05-09 07:27:52 UTC

@kirkwaiblingerkirkwaiblinger changed the titlechore(typescript-eslint): rename import of typescript-eslint in testchore(typescript-eslint): correct naming of import of typescript-eslint in testMay 8, 2025
Copy link
Member

@ronamironami left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀🚀 Nice! That aligns it to the other similar import in

kirkwaiblinger reacted with laugh emoji
@ronamironami added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 9, 2025
@kirkwaiblingerkirkwaiblinger merged commite57126a intotypescript-eslint:mainMay 9, 2025
64 of 65 checks passed
@kirkwaiblingerkirkwaiblinger deleted the plugin-to-tseslint branchMay 9, 2025 08:46
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ronamironamironami approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kirkwaiblinger@ronami@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp