typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore: update`eslint-plugin-perfectionist` to`v4`#11185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kirkwaiblinger merged 9 commits intotypescript-eslint:mainfromhugop95:feat/perfectionist-v4

May 16, 2025

Merged

chore: update`eslint-plugin-perfectionist` to`v4`#11185

kirkwaiblinger merged 9 commits intotypescript-eslint:mainfromhugop95:feat/perfectionist-v4

May 16, 2025

Conversation

Copy link

Contributor

hugop95 commentedMay 7, 2025•
edited by kirkwaiblinger
Loading

Issue:Repo: updateeslint-plugin-perfectionist tov4 #11186
Follow-up ofchore: applied eslint-plugin-perfectionist@4 updates #11168
- Original issue:Repo: eslint-plugin-perfectionist@4 code updates not reflected onmain #11169

PR Checklist

Addresses an existing open issue:fixesRepo: updateeslint-plugin-perfectionist tov4 #11186
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Updatingperfectionist from V3 to V4 requires a couple of changes in the Eslint configuration.

This PR updates the config in order to have the minimal amount of changes in the codebase.

hugop95 added3 commits

May 7, 2025 12:41

chore: update dependencies

a83902c

chore: update eslint config

61dbefe

- `perfectionist` v4 uses RegExp to match, and `type` will match `typeSomething`, unlike in v3 which used `minimatch` by default.

chore:sort-classes fixes

a84726f

- The default `groups` option was updated in v4 (azat-io/eslint-plugin-perfectionist#320). Forcing back to v3 default option.

Copy link

Contributor

typescript-eslintbot commentedMay 7, 2025

Thanks for the PR,@hugop95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMay 7, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`15260e5`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68274357a5c95f000874a90d
😎 Deploy Preview	https://deploy-preview-11185--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 84 (🔴 down 15 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedMay 7, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit15260e5.

Command	Status	Duration	Result
`nx test eslint-plugin`	✅ Succeeded	6m 27s	View ↗
`nx test typescript-estree`	✅ Succeeded	45s	View ↗
`nx run eslint-plugin:test -- --coverage`	✅ Succeeded	6m 27s	View ↗
`nx test type-utils`	✅ Succeeded	23s	View ↗
`nx run types:build`	✅ Succeeded	1s	View ↗
`nx test scope-manager`	✅ Succeeded	19s	View ↗
`nx typecheck ast-spec`	✅ Succeeded	2s	View ↗
`nx test utils`	✅ Succeeded	12s	View ↗
`Additional runs (26)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-05-16 14:13:04 UTC

hugop95 added3 commits

May 7, 2025 13:12

chore:sort-imports fixes

ddaa64f

chore:sort-objects fixes

b72db25

chore:sort-union-types fixes

1a1ba0d

- This is where most of the changes are.

hugop95 force-pushed thefeat/perfectionist-v4 branch from48d140b to1a1ba0dCompare

May 7, 2025 11:13

hugop95 changed the title~~chore: updateperfectionist tov4~~chore: updateeslint-plugin-perfectionist tov4

May 7, 2025

hugop95 mentioned this pull request

May 7, 2025

Repo: updateeslint-plugin-perfectionist tov4#11186

Closed

Copy link

codecovbot commentedMay 7, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base(d2dfe73) to head(15260e5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11185   +/-   ##=======================================  Coverage   90.92%   90.92%           =======================================  Files         499      499             Lines       50845    50845             Branches     8384     8384           =======================================  Hits        46231    46231             Misses       4599     4599             Partials       15       15

Flag	Coverage Δ
unittest	`90.92% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...ges/eslint-plugin/src/rules/no-restricted-types.ts	`93.98% <100.00%> (ø)`
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`98.26% <ø> (ø)`
...s/eslint-plugin/src/util/collectUnusedVariables.ts	`96.19% <ø> (ø)`
...ackages/scope-manager/src/referencer/Referencer.ts	`97.94% <ø> (ø)`
packages/type-utils/src/isUnsafeAssignment.ts	`90.54% <100.00%> (ø)`
packages/utils/src/ts-eslint/SourceCode.ts	`100.00% <ø> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hugop95 mentioned this pull request

May 7, 2025

chore: applied eslint-plugin-perfectionist@4 updates#11168

Closed

3 tasks

kirkwaiblinger previously approved these changes

May 14, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger commentedMay 14, 2025

Thanks for sending this in! Looks good to me! I've gone ahead and reviewed/approved this since I'm guessing it was only drafted due to waiting on the "accepting PRs" label, but we'll wait for you to undraft it in case there's anything else that needs to be done before merging. Also, would you mind merging in from main and resolving the merge conflicts when you undraft? Thanks!