Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: create standalone project-service, tsconfig-utils packages#11182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedMay 6, 2025•
edited
Loading

PR Checklist

Overview

Creates two new packages:

  • @typescript-eslint/project-service: with thecreateProjectService function used by@typescript-eslint/typescript-estree within@typescript-eslint/parser
  • @typescript-eslint/tsconfig-utils: with thegetParsedConfigFile function used in both the newly movedcreateProjectService and not-moveduseProvidedPrograms function

Neither have any runtime dependencies on any ESLint or other typescript-eslint packages. The only internal production package dependency isproject-service relying on@typescript-eslint/types for the sharedProjectServiceOptions interface.

Notably does not change the@typescript-eslint/types package, even though that's whereProjectServiceOptions is declared right now. Moving that interface into the new@typescript-eslint/project-service package would meanParserOptions would have a dependency on a package with runtime code. No go.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 6, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit572acf5
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/682cad4ca3aa8e0008e087c1
😎 Deploy Previewhttps://deploy-preview-11182--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 6, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit572acf5.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded4m 58sView ↗
nx run-many -t typecheck✅ Succeeded2m 11sView ↗
nx run integration-tests:test✅ Succeeded45sView ↗
nx test typescript-estree --coverage=false✅ Succeeded19sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded6sView ↗
nx run-many -t lint✅ Succeeded9sView ↗
nx typecheck ast-spec✅ Succeeded<1sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-05-20 16:39:29 UTC

) {
const options = typeof optionsRaw === 'object' ? optionsRaw : {};

validateDefaultProjectForFilesGlob(options.allowDefaultProject);
Copy link
MemberAuthor

@JoshuaKGoldbergJoshuaKGoldbergMay 6, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I created thispopulateProjectService function here so that it could be what runsvalidateDefaultProjectForFilesGlob, instead ofcreateProjectService. This way we don't need to also movevalidateDefaultProjectForFilesGlob into the new@typescript-eslint/project-service package.

In other words: validating default project globs is not a part of the new package. That's still specific to typescript-estree.

@codecovCodecov
Copy link

codecovbot commentedMay 6, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is98.85057% with1 line in your changes missing coverage. Please review.

Project coverage is 90.91%. Comparing base(9335077) to head(572acf5).
Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
...pt-estree/src/parseSettings/createParseSettings.ts94.11%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main   #11182      +/-   ##==========================================- Coverage   90.92%   90.91%   -0.01%==========================================  Files         499      501       +2       Lines       50847    50869      +22       Branches     8384     8382       -2     ==========================================+ Hits        46233    46248      +15- Misses       4599     4606       +7  Partials       15       15
FlagCoverage Δ
unittest90.91% <98.85%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...ckages/project-service/src/createProjectService.ts98.27% <100.00%> (ø)
...ect-service/src/getParsedConfigFileFromTSServer.ts100.00% <100.00%> (ø)
packages/tsconfig-utils/src/compilerOptions.ts100.00% <100.00%> (ø)
packages/tsconfig-utils/src/getParsedConfigFile.ts91.30% <100.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts87.80% <100.00%> (-0.57%)⬇️
...t-estree/src/create-program/useProvidedPrograms.ts100.00% <100.00%> (ø)
...escript-estree/src/useProgramFromProjectService.ts100.00% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts92.14% <94.11%> (-0.04%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewMay 12, 2025 12:10
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftMay 12, 2025 12:10
@JoshuaKGoldbergJoshuaKGoldbergforce-pushed thestandalone-project-service branch 2 times, most recently fromb32a113 tocaa57bbCompareMay 12, 2025 14:42
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewMay 12, 2025 14:42
@JoshuaKGoldbergJoshuaKGoldberg requested review froma team andbradzacherMay 12, 2025 14:42
bradzacher
bradzacher previously approved these changesMay 19, 2025
Copy link
Member

@JamesHenryJamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please update and align with latest main

Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldbergJoshuaKGoldberg merged commit4ad8a07 intotypescript-eslint:mainMay 21, 2025
64 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the standalone-project-service branchMay 21, 2025 11:42
@fisker
Copy link
Contributor

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Split out a@typescript-eslint/project-service package
4 participants
@JoshuaKGoldberg@fisker@JamesHenry@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp