typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for`TSMappedType` with no type annotation#11180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromronami:consistent-object-style-ts-mapped-type-no-annotation

May 12, 2025

Merged

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for`TSMappedType` with no type annotation#11180

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromronami:consistent-object-style-ts-mapped-type-no-annotation

May 12, 2025

+15 −3

Conversation

Copy link

Member

ronami commentedMay 6, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [consistent-indexed-object-style] auto-fixer generates invalid syntax forTSMappedType with no type annotation #11179
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR addresses#11179 and adjusts the auto-fixer to fix the following:

typeBar={[kinstring];};

Into:

typeBar=Record<string,any>;

initial implementation

e2e7839

Copy link

Contributor

typescript-eslintbot commentedMay 6, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMay 6, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ccd2307`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/681a200990c19d00088f488a
😎 Deploy Preview	https://deploy-preview-11180--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedMay 6, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitccd2307.

Command	Status	Duration	Result
`nx typecheck ast-spec`	✅ Succeeded	<1s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	5s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️Nx Cloud last updated this comment at2025-05-06 14:57:06 UTC

Copy link

codecovbot commentedMay 6, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base(d5209cd) to head(ccd2307).
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11180   +/-   ##=======================================  Coverage   90.91%   90.91%           =======================================  Files         499      499             Lines       50809    50809             Branches     8369     8371    +2     =======================================  Hits        46195    46195             Misses       4599     4599             Partials       15       15

Flag	Coverage Δ
unittest	`90.91% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...lugin/src/rules/consistent-indexed-object-style.ts	`99.31% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

naming

ccd2307

ronami marked this pull request as ready for review

May 6, 2025 14:57

ronami mentioned this pull request

May 6, 2025

fix(eslint-plugin): [consistent-indexed-object-style] check for indirect circular types in aliased mapped types#11177

Merged

3 tasks

kirkwaiblinger approved these changes

May 7, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

JoshuaKGoldberg approved these changes

May 12, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice and clean 🔥

JoshuaKGoldberg merged commit98c5c4c intotypescript-eslint:main

May 12, 2025

57 checks passed

ronami deleted the consistent-object-style-ts-mapped-type-no-annotation branch

May 12, 2025 20:38

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

May 17, 2025

Update typescript-eslint monorepo to v8.32.1

9161c18

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.31.0 | 8.32.1 || npm        | @typescript-eslint/parser        | 8.31.0 | 8.32.1 |## [v8.32.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8321-2025-05-12)##### 🩹 Fixes-   **eslint-plugin:** \[consistent-indexed-object-style] check for indirect circular types in aliased mapped types ([#11177](typescript-eslint/typescript-eslint#11177))-   **eslint-plugin:** \[consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for `TSMappedType` with no type annotation ([#11180](typescript-eslint/typescript-eslint#11180))-   **eslint-plugin:** \[no-deprecated] support computed member access ([#10867](typescript-eslint/typescript-eslint#10867))-   **eslint-plugin:** \[no-unnecessary-type-conversion] shouldn't have fixable property ([#11194](typescript-eslint/typescript-eslint#11194))##### ❤️ Thank You-   Azat S. [@azat-io](https://github.com/azat-io)-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.32.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8320-2025-05-05)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add option `allowRethrowing` ([#11075](typescript-eslint/typescript-eslint#11075))-   **eslint-plugin:** \[no-unnecessary-type-conversion] add rule ([#10182](typescript-eslint/typescript-eslint#10182))##### 🩹 Fixes-   **eslint-plugin:** \[prefer-nullish-coalescing] fix parenthesization bug in suggestion ([#11098](typescript-eslint/typescript-eslint#11098))-   **eslint-plugin:** \[unified-signatures] exempt `this` from optional parameter overload check ([#11005](typescript-eslint/typescript-eslint#11005))-   **eslint-plugin:** \[no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary ([#10907](typescript-eslint/typescript-eslint#10907))##### ❤️ Thank You-   Andy Edwards-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   Sasha Kondrashov-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.31.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8311-2025-04-28)##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] downgrade fix to suggestion ([#11081](typescript-eslint/typescript-eslint#11081))##### ❤️ Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

May 20, 2025

Labels

None yet

3 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for`TSMappedType` with no type annotation#11180

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for`TSMappedType` with no type annotation#11180

Conversation

ronami commentedMay 6, 2025•
edited
Loading

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedMay 6, 2025

Uh oh!

netlifybot commentedMay 6, 2025•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedMay 6, 2025•
edited
Loading

Uh oh!

Uh oh!

codecovbot commentedMay 6, 2025•
edited
Loading

Uh oh!

Codecov Report

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax forTSMappedType with no type annotation#11180

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax forTSMappedType with no type annotation#11180

Conversation

ronami commentedMay 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedMay 6, 2025

Uh oh!

netlifybot commentedMay 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedMay 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedMay 6, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for`TSMappedType` with no type annotation#11180

fix(eslint-plugin): [consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for`TSMappedType` with no type annotation#11180

ronami commentedMay 6, 2025•
edited
Loading

netlifybot commentedMay 6, 2025•
edited
Loading

nx-cloudbot commentedMay 6, 2025•
edited
Loading

codecovbot commentedMay 6, 2025•
edited
Loading