Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [consistent-indexed-object-style] check for indirect circular types in aliased mapped types#11177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ronami
Copy link
Member

@ronamironami commentedMay 5, 2025•
edited
Loading

PR Checklist

Overview

This PR addresses#11121 and changes the current circular check for aliased mapped types to useisDeeplyReferencingType which also checks for indirect circular types.

Edit: Once#11180 is merged, codecov should be green (unable to add the test currently since it breaks syntax).

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 5, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitad40be8
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6821e93ca03bc40008ab1dd2
😎 Deploy Previewhttps://deploy-preview-11177--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 93 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 5, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitad40be8.

CommandStatusDurationResult
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded15sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-05-12 12:40:37 UTC

@codecovCodecov
Copy link

codecovbot commentedMay 5, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base(b2be3dc) to head(ad40be8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11177   +/-   ##=======================================  Coverage   90.92%   90.92%           =======================================  Files         499      499             Lines       50841    50845    +4       Branches     8380     8384    +4     =======================================+ Hits        46227    46231    +4  Misses       4599     4599             Partials       15       15
FlagCoverage Δ
unittest90.92% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...lugin/src/rules/consistent-indexed-object-style.ts99.32% <100.00%> (+<0.01%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronami
Copy link
MemberAuthor

ronami commentedMay 6, 2025•
edited
Loading

Once#11180 is merged, codecov should be green (unable to add the test currently since it breaks syntax).

@ronamironami marked this pull request as ready for reviewMay 6, 2025 15:07
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! +1 to continuing to useisDeeplyReferencingType more.

I'll try to get this merged up now for the weekly release later today.

ronami reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 12, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commitf8db925 intotypescript-eslint:mainMay 12, 2025
53 checks passed
@ronamironami deleted the circular-mapped-types branchMay 12, 2025 20:38
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestMay 17, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.31.0 | 8.32.1 || npm        | @typescript-eslint/parser        | 8.31.0 | 8.32.1 |## [v8.32.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8321-2025-05-12)##### 🩹 Fixes-   **eslint-plugin:** \[consistent-indexed-object-style] check for indirect circular types in aliased mapped types ([#11177](typescript-eslint/typescript-eslint#11177))-   **eslint-plugin:** \[consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for `TSMappedType` with no type annotation ([#11180](typescript-eslint/typescript-eslint#11180))-   **eslint-plugin:** \[no-deprecated] support computed member access ([#10867](typescript-eslint/typescript-eslint#10867))-   **eslint-plugin:** \[no-unnecessary-type-conversion] shouldn't have fixable property ([#11194](typescript-eslint/typescript-eslint#11194))##### ❤️ Thank You-   Azat S. [@azat-io](https://github.com/azat-io)-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.32.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8320-2025-05-05)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add option `allowRethrowing` ([#11075](typescript-eslint/typescript-eslint#11075))-   **eslint-plugin:** \[no-unnecessary-type-conversion] add rule ([#10182](typescript-eslint/typescript-eslint#10182))##### 🩹 Fixes-   **eslint-plugin:** \[prefer-nullish-coalescing] fix parenthesization bug in suggestion ([#11098](typescript-eslint/typescript-eslint#11098))-   **eslint-plugin:** \[unified-signatures] exempt `this` from optional parameter overload check ([#11005](typescript-eslint/typescript-eslint#11005))-   **eslint-plugin:** \[no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary ([#10907](typescript-eslint/typescript-eslint#10907))##### ❤️ Thank You-   Andy Edwards-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   Sasha Kondrashov-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.31.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8311-2025-04-28)##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] downgrade fix to suggestion ([#11081](typescript-eslint/typescript-eslint#11081))##### ❤️ Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [consistent-indexed-object-style] type with recursive index signature autofixed to Record instead of mapped type
2 participants
@ronami@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp