May 5, 2025 · May 5, 2025
diff --git a/eslint.config.mjs b/eslint.config.mjs
 // @ts-check

 import eslintCommentsPlugin from '@eslint-community/eslint-plugin-eslint-comments/configs';
 import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
 import { FlatCompat } from '@eslint/eslintrc';
 import eslint from '@eslint/js';
 import eslintCommentsPlugin from '@eslint-community/eslint-plugin-eslint-comments/configs';
 import tseslintInternalPlugin from '@typescript-eslint/eslint-plugin-internal';
 import vitestPlugin from '@vitest/eslint-plugin';
 import eslintPluginPlugin from 'eslint-plugin-eslint-plugin';
diff --git a/packages/ast-spec/src/base/PropertyDefinitionBase.ts b/packages/ast-spec/src/base/PropertyDefinitionBase.ts
 import type { BaseNode } from './BaseNode';

 interface PropertyDefinitionBase extends BaseNode {
  typeAnnotation: TSTypeAnnotation | undefined;
  accessibility: Accessibility | undefined;
  computed: boolean;
  declare: boolean;
  override: boolean;
  readonly: boolean;
  static: boolean;
  typeAnnotation: TSTypeAnnotation | undefined;
  value: Expression | null;
 }

diff --git a/packages/ast-spec/src/base/TSFunctionSignatureBase.ts b/packages/ast-spec/src/base/TSFunctionSignatureBase.ts
 import type { BaseNode } from './BaseNode';

 export interface TSFunctionSignatureBase extends BaseNode {
  typeParameters: TSTypeParameterDeclaration | undefined;
  params: Parameter[];
  returnType: TSTypeAnnotation | undefined;
  typeParameters: TSTypeParameterDeclaration | undefined;
 }
diff --git a/packages/ast-spec/src/base/TSHeritageBase.ts b/packages/ast-spec/src/base/TSHeritageBase.ts

 export interface TSHeritageBase extends BaseNode {
  // TODO(#1852) - this should be restricted to MemberExpression | Identifier
  expression: Expression;
  typeArguments: TSTypeParameterInstantiation | undefined;
  expression: Expression;
 }
diff --git a/packages/ast-spec/src/element/TSIndexSignature/spec.ts b/packages/ast-spec/src/element/TSIndexSignature/spec.ts

 export interface TSIndexSignature extends BaseNode {
  type: AST_NODE_TYPES.TSIndexSignature;
  typeAnnotation: TSTypeAnnotation | undefined;
  accessibility: Accessibility | undefined;
  parameters: Parameter[];
  readonly: boolean;
  static: boolean;
  typeAnnotation: TSTypeAnnotation | undefined;
 }
diff --git a/packages/ast-spec/src/element/TSMethodSignature/spec.ts b/packages/ast-spec/src/element/TSMethodSignature/spec.ts

 interface TSMethodSignatureBase extends BaseNode {
  type: AST_NODE_TYPES.TSMethodSignature;
  typeParameters: TSTypeParameterDeclaration | undefined;
  accessibility: Accessibility | undefined;
  computed: boolean;
  key: PropertyName;
  readonly: boolean;
  returnType: TSTypeAnnotation | undefined;
  static: boolean;
  typeParameters: TSTypeParameterDeclaration | undefined;
 }

 export interface TSMethodSignatureComputedName extends TSMethodSignatureBase {
diff --git a/packages/ast-spec/src/element/TSPropertySignature/spec.ts b/packages/ast-spec/src/element/TSPropertySignature/spec.ts

 interface TSPropertySignatureBase extends BaseNode {
  type: AST_NODE_TYPES.TSPropertySignature;
  typeAnnotation: TSTypeAnnotation | undefined;
  accessibility: Accessibility | undefined;
  computed: boolean;
  key: PropertyName;
  optional: boolean;
  readonly: boolean;
  static: boolean;
  typeAnnotation: TSTypeAnnotation | undefined;
 }

 export interface TSPropertySignatureComputedName
diff --git a/packages/ast-spec/src/expression/ArrowFunctionExpression/spec.ts b/packages/ast-spec/src/expression/ArrowFunctionExpression/spec.ts

 export interface ArrowFunctionExpression extends BaseNode {
  type: AST_NODE_TYPES.ArrowFunctionExpression;
  typeParameters: TSTypeParameterDeclaration | undefined;
  async: boolean;
  body: BlockStatement | Expression;
  expression: boolean;
  generator: boolean;
  id: null;
  params: Parameter[];
  returnType: TSTypeAnnotation | undefined;
  typeParameters: TSTypeParameterDeclaration | undefined;
 }
diff --git a/packages/ast-spec/src/expression/CallExpression/spec.ts b/packages/ast-spec/src/expression/CallExpression/spec.ts

 export interface CallExpression extends BaseNode {
  type: AST_NODE_TYPES.CallExpression;
  typeArguments: TSTypeParameterInstantiation | undefined;
  arguments: CallExpressionArgument[];
  callee: Expression;
  optional: boolean;
  typeArguments: TSTypeParameterInstantiation | undefined;
 }
diff --git a/packages/ast-spec/src/expression/Identifier/spec.ts b/packages/ast-spec/src/expression/Identifier/spec.ts

 export interface Identifier extends BaseNode {
  type: AST_NODE_TYPES.Identifier;
  typeAnnotation: TSTypeAnnotation | undefined;
  decorators: Decorator[];
  name: string;
  optional: boolean;
  typeAnnotation: TSTypeAnnotation | undefined;
 }
diff --git a/packages/ast-spec/src/expression/NewExpression/spec.ts b/packages/ast-spec/src/expression/NewExpression/spec.ts

 export interface NewExpression extends BaseNode {
  type: AST_NODE_TYPES.NewExpression;
  typeArguments: TSTypeParameterInstantiation | undefined;
  arguments: CallExpressionArgument[];
  callee: Expression;
  typeArguments: TSTypeParameterInstantiation | undefined;
 }
diff --git a/packages/ast-spec/src/expression/TSAsExpression/spec.ts b/packages/ast-spec/src/expression/TSAsExpression/spec.ts

 export interface TSAsExpression extends BaseNode {
  type: AST_NODE_TYPES.TSAsExpression;
  expression: Expression;
  typeAnnotation: TypeNode;
  expression: Expression;
 }
diff --git a/packages/ast-spec/src/expression/TSInstantiationExpression/spec.ts b/packages/ast-spec/src/expression/TSInstantiationExpression/spec.ts

 export interface TSInstantiationExpression extends BaseNode {
  type: AST_NODE_TYPES.TSInstantiationExpression;
  expression: Expression;
  typeArguments: TSTypeParameterInstantiation;
  expression: Expression;
 }
diff --git a/packages/ast-spec/src/expression/TSSatisfiesExpression/spec.ts b/packages/ast-spec/src/expression/TSSatisfiesExpression/spec.ts

 export interface TSSatisfiesExpression extends BaseNode {
  type: AST_NODE_TYPES.TSSatisfiesExpression;
  expression: Expression;
  typeAnnotation: TypeNode;
  expression: Expression;
 }
diff --git a/packages/ast-spec/src/expression/TSTypeAssertion/spec.ts b/packages/ast-spec/src/expression/TSTypeAssertion/spec.ts

 export interface TSTypeAssertion extends BaseNode {
  type: AST_NODE_TYPES.TSTypeAssertion;
  expression: Expression;
  typeAnnotation: TypeNode;
  expression: Expression;
 }
diff --git a/packages/ast-spec/src/expression/TaggedTemplateExpression/spec.ts b/packages/ast-spec/src/expression/TaggedTemplateExpression/spec.ts

 export interface TaggedTemplateExpression extends BaseNode {
  type: AST_NODE_TYPES.TaggedTemplateExpression;
  typeArguments: TSTypeParameterInstantiation | undefined;
  quasi: TemplateLiteral;
  tag: Expression;
  typeArguments: TSTypeParameterInstantiation | undefined;
 }
diff --git a/packages/ast-spec/src/expression/UnaryExpression/spec.ts b/packages/ast-spec/src/expression/UnaryExpression/spec.ts

 export interface UnaryExpression extends UnaryExpressionBase {
  type: AST_NODE_TYPES.UnaryExpression;
  operator: '!' | '+' | '~' | '-' | 'delete' | 'typeof' | 'void';
  operator: '!' | '+' | '-' | 'delete' | 'typeof' | 'void' | '~';
 }
diff --git a/packages/ast-spec/src/jsx/JSXOpeningElement/spec.ts b/packages/ast-spec/src/jsx/JSXOpeningElement/spec.ts

 export interface JSXOpeningElement extends BaseNode {
  type: AST_NODE_TYPES.JSXOpeningElement;
  typeArguments: TSTypeParameterInstantiation | undefined;
  attributes: (JSXAttribute | JSXSpreadAttribute)[];
  name: JSXTagNameExpression;
  selfClosing: boolean;
  typeArguments: TSTypeParameterInstantiation | undefined;
 }
diff --git a/packages/ast-spec/src/parameter/ArrayPattern/spec.ts b/packages/ast-spec/src/parameter/ArrayPattern/spec.ts

 export interface ArrayPattern extends BaseNode {
  type: AST_NODE_TYPES.ArrayPattern;
  typeAnnotation: TSTypeAnnotation | undefined;
  decorators: Decorator[];
  elements: (DestructuringPattern | null)[];
  optional: boolean;
  typeAnnotation: TSTypeAnnotation | undefined;
 }
diff --git a/packages/ast-spec/src/parameter/AssignmentPattern/spec.ts b/packages/ast-spec/src/parameter/AssignmentPattern/spec.ts

 export interface AssignmentPattern extends BaseNode {
  type: AST_NODE_TYPES.AssignmentPattern;
  typeAnnotation: TSTypeAnnotation | undefined;
  decorators: Decorator[];
  left: BindingName;
  optional: boolean;
  right: Expression;
  typeAnnotation: TSTypeAnnotation | undefined;
 }
diff --git a/packages/ast-spec/src/parameter/ObjectPattern/spec.ts b/packages/ast-spec/src/parameter/ObjectPattern/spec.ts

 export interface ObjectPattern extends BaseNode {
  type: AST_NODE_TYPES.ObjectPattern;
  typeAnnotation: TSTypeAnnotation | undefined;
  decorators: Decorator[];
  optional: boolean;
  properties: (Property | RestElement)[];
  typeAnnotation: TSTypeAnnotation | undefined;
 }
diff --git a/packages/ast-spec/src/parameter/RestElement/spec.ts b/packages/ast-spec/src/parameter/RestElement/spec.ts

 export interface RestElement extends BaseNode {
  type: AST_NODE_TYPES.RestElement;
  typeAnnotation: TSTypeAnnotation | undefined;
  argument: DestructuringPattern;
  decorators: Decorator[];
  optional: boolean;
  typeAnnotation: TSTypeAnnotation | undefined;
  value: AssignmentPattern | undefined;
 }
diff --git a/packages/ast-spec/src/type/TSImportType/spec.ts b/packages/ast-spec/src/type/TSImportType/spec.ts

 export interface TSImportType extends BaseNode {
  type: AST_NODE_TYPES.TSImportType;
  typeArguments: TSTypeParameterInstantiation | null;
  argument: TypeNode;
  options: ObjectExpression | null;
  qualifier: EntityName | null;
  typeArguments: TSTypeParameterInstantiation | null;
 }
diff --git a/packages/ast-spec/src/type/TSMappedType/spec.ts b/packages/ast-spec/src/type/TSMappedType/spec.ts

 export interface TSMappedType extends BaseNode {
  type: AST_NODE_TYPES.TSMappedType;
  typeAnnotation: TypeNode | undefined;
  constraint: TypeNode;
  key: Identifier;
  nameType: TypeNode | null;
  optional: boolean | '+' | '-' | undefined;
  readonly: boolean | '+' | '-' | undefined;
  typeAnnotation: TypeNode | undefined;
  /** @deprecated Use {@link `constraint`} and {@link `key`} instead. */
  typeParameter: TSTypeParameter;
 }
diff --git a/packages/ast-spec/src/type/TSTemplateLiteralType/spec.ts b/packages/ast-spec/src/type/TSTemplateLiteralType/spec.ts

 export interface TSTemplateLiteralType extends BaseNode {
  type: AST_NODE_TYPES.TSTemplateLiteralType;
  quasis: TemplateElement[];
  types: TypeNode[];
  quasis: TemplateElement[];
 }
diff --git a/packages/ast-spec/src/type/TSTypeOperator/spec.ts b/packages/ast-spec/src/type/TSTypeOperator/spec.ts

 export interface TSTypeOperator extends BaseNode {
  type: AST_NODE_TYPES.TSTypeOperator;
  operator: 'keyof' | 'readonly' | 'unique';
  typeAnnotation: TypeNode | undefined;
  operator: 'keyof' | 'readonly' | 'unique';
 }
diff --git a/packages/ast-spec/src/type/TSTypePredicate/spec.ts b/packages/ast-spec/src/type/TSTypePredicate/spec.ts

 export interface TSTypePredicate extends BaseNode {
  type: AST_NODE_TYPES.TSTypePredicate;
  typeAnnotation: TSTypeAnnotation | null;
  asserts: boolean;
  parameterName: Identifier | TSThisType;
  typeAnnotation: TSTypeAnnotation | null;
 }
diff --git a/packages/ast-spec/src/type/TSTypeQuery/spec.ts b/packages/ast-spec/src/type/TSTypeQuery/spec.ts

 export interface TSTypeQuery extends BaseNode {
  type: AST_NODE_TYPES.TSTypeQuery;
  exprName: EntityName | TSImportType;
  typeArguments: TSTypeParameterInstantiation | undefined;
  exprName: EntityName | TSImportType;
 }
diff --git a/packages/eslint-plugin-internal/src/rules/debug-namespace.ts b/packages/eslint-plugin-internal/src/rules/debug-namespace.ts
  name: __filename,
  meta: {
    type: 'problem',
    fixable: 'code',
    docs: {
      description:
        'Enforce consistent debug() namespaces based on package name and file path',
    },
    fixable: 'code',
    messages: {
      mismatched:
        'debug() namespace should match package and file. Use the fixer to update it.',
diff --git a/packages/eslint-plugin-internal/src/rules/eqeq-nullish.ts b/packages/eslint-plugin-internal/src/rules/eqeq-nullish.ts
  name: __filename,
  meta: {
    type: 'suggestion',
    fixable: 'code',
    docs: {
      description: 'Enforce eqeqeq preferences around nullish comparisons',
    },
    fixable: 'code',
    hasSuggestions: true,
    messages: {
      unexpectedComparison:
diff --git a/packages/eslint-plugin-internal/src/rules/index.ts b/packages/eslint-plugin-internal/src/rules/index.ts

 export default {
  'debug-namespace': debugNamespace,
  'eqeq-nullish': eqeqNullish,
  'no-poorly-typed-ts-props': noPoorlyTypedTsProps,
  'no-relative-paths-to-internal-packages': noRelativePathsToInternalPackages,
  'no-typescript-default-import': noTypescriptDefaultImport,
  'no-typescript-estree-import': noTypescriptEstreeImport,
  'plugin-test-formatting': pluginTestFormatting,
  'prefer-ast-types-enum': preferASTTypesEnum,
  'eqeq-nullish': eqeqNullish,
  'no-relative-paths-to-internal-packages': noRelativePathsToInternalPackages,
  'plugin-test-formatting': pluginTestFormatting,
 } satisfies Linter.PluginRules;
diff --git a/packages/eslint-plugin-internal/src/rules/no-poorly-typed-ts-props.ts b/packages/eslint-plugin-internal/src/rules/no-poorly-typed-ts-props.ts
  name: 'no-poorly-typed-ts-props',
  meta: {
    type: 'problem',
    fixable: 'code',
    docs: {
      description:
        "Enforce that rules don't use TS API properties with known bad type definitions",
      requiresTypeChecking: true,
    },
    fixable: 'code',
    hasSuggestions: true,
    messages: {
      doNotUse: 'Do not use {{type}}.{{property}} because it is poorly typed.',
diff --git a/packages/eslint-plugin-internal/src/rules/no-relative-paths-to-internal-packages.ts b/packages/eslint-plugin-internal/src/rules/no-relative-paths-to-internal-packages.ts
  name: __filename,
  meta: {
    type: 'problem',
    fixable: 'code',
    docs: {
      description: 'Disallow relative paths to internal packages',
    },
    fixable: 'code',
    messages: {
      noRelativePathsToInternalPackages:
        'Use absolute paths instead of relative paths to import modules in other internal packages.',
diff --git a/packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts b/packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts
  name: 'no-typescript-default-import',
  meta: {
    type: 'problem',
    fixable: 'code',
    docs: {
      description:
        "Enforce that packages rules don't do `import ts from 'typescript';`",
    },
    fixable: 'code',
    messages: {
      noTSDefaultImport: [
        "Do not use the default import for typescript. Doing so will cause the package's type definitions to do the same.",
diff --git a/packages/eslint-plugin-internal/src/rules/no-typescript-estree-import.ts b/packages/eslint-plugin-internal/src/rules/no-typescript-estree-import.ts
  name: 'no-typescript-estree-import',
  meta: {
    type: 'problem',
    fixable: 'code',
    docs: {
      description: `Enforce that eslint-plugin rules don't require anything from ${TSESTREE_NAME} or ${TYPES_NAME}`,
    },
    fixable: 'code',
    messages: {
      dontImportPackage: [
        `Don't import from {{packageName}}. Everything you need should be available in ${UTILS_NAME}.`,
diff --git a/packages/eslint-plugin-internal/src/rules/plugin-test-formatting.ts b/packages/eslint-plugin-internal/src/rules/plugin-test-formatting.ts
  name: 'plugin-test-formatting',
  meta: {
    type: 'problem',
    fixable: 'code',
    docs: {
      description: `Enforce that eslint-plugin test snippets are correctly formatted`,
      requiresTypeChecking: true,
    },
    fixable: 'code',
    messages: {
      invalidFormatting:
        'This snippet should be formatted correctly. Use the fixer to format the code.',
Original file line number	Diff line number	Diff line change
		@@ -1,9 +1,9 @@
		// @ts-check

		import eslintCommentsPlugin from '@eslint-community/eslint-plugin-eslint-comments/configs';
		import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
		import { FlatCompat } from '@eslint/eslintrc';
		import eslint from '@eslint/js';
		import eslintCommentsPlugin from '@eslint-community/eslint-plugin-eslint-comments/configs';
		import tseslintInternalPlugin from '@typescript-eslint/eslint-plugin-internal';
		import vitestPlugin from '@vitest/eslint-plugin';
		import eslintPluginPlugin from 'eslint-plugin-eslint-plugin';
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -11,6 +11,7 @@ import type { Accessibility } from './Accessibility';
		import type { BaseNode } from './BaseNode';

		interface PropertyDefinitionBase extends BaseNode {
		typeAnnotation: TSTypeAnnotation \| undefined;
		accessibility: Accessibility \| undefined;
		computed: boolean;
		declare: boolean;
Expand All		@@ -21,7 +22,6 @@ interface PropertyDefinitionBase extends BaseNode {
		override: boolean;
		readonly: boolean;
		static: boolean;
		typeAnnotation: TSTypeAnnotation \| undefined;
		value: Expression \| null;
		}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,7 +4,7 @@ import type { Parameter } from '../unions/Parameter';
		import type { BaseNode } from './BaseNode';

		export interface TSFunctionSignatureBase extends BaseNode {
		typeParameters: TSTypeParameterDeclaration \| undefined;
		params: Parameter[];
		returnType: TSTypeAnnotation \| undefined;
		typeParameters: TSTypeParameterDeclaration \| undefined;
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,6 +4,6 @@ import type { BaseNode } from './BaseNode';

		export interface TSHeritageBase extends BaseNode {
		// TODO(#1852) - this should be restricted to MemberExpression \| Identifier
		expression: Expression;
		typeArguments: TSTypeParameterInstantiation \| undefined;
		expression: Expression;
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,9 +6,9 @@ import type { Parameter } from '../../unions/Parameter';

		export interface TSIndexSignature extends BaseNode {
		type: AST_NODE_TYPES.TSIndexSignature;
		typeAnnotation: TSTypeAnnotation \| undefined;
		accessibility: Accessibility \| undefined;
		parameters: Parameter[];
		readonly: boolean;
		static: boolean;
		typeAnnotation: TSTypeAnnotation \| undefined;
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -12,6 +12,7 @@ import type {

		interface TSMethodSignatureBase extends BaseNode {
		type: AST_NODE_TYPES.TSMethodSignature;
		typeParameters: TSTypeParameterDeclaration \| undefined;
		accessibility: Accessibility \| undefined;
		computed: boolean;
		key: PropertyName;
Expand All		@@ -21,7 +22,6 @@ interface TSMethodSignatureBase extends BaseNode {
		readonly: boolean;
		returnType: TSTypeAnnotation \| undefined;
		static: boolean;
		typeParameters: TSTypeParameterDeclaration \| undefined;
		}

		export interface TSMethodSignatureComputedName extends TSMethodSignatureBase {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,13 +10,13 @@ import type {

		interface TSPropertySignatureBase extends BaseNode {
		type: AST_NODE_TYPES.TSPropertySignature;
		typeAnnotation: TSTypeAnnotation \| undefined;
		accessibility: Accessibility \| undefined;
		computed: boolean;
		key: PropertyName;
		optional: boolean;
		readonly: boolean;
		static: boolean;
		typeAnnotation: TSTypeAnnotation \| undefined;
		}

		export interface TSPropertySignatureComputedName
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,12 +8,12 @@ import type { Parameter } from '../../unions/Parameter';

		export interface ArrowFunctionExpression extends BaseNode {
		type: AST_NODE_TYPES.ArrowFunctionExpression;
		typeParameters: TSTypeParameterDeclaration \| undefined;
		async: boolean;
		body: BlockStatement \| Expression;
		expression: boolean;
		generator: boolean;
		id: null;
		params: Parameter[];
		returnType: TSTypeAnnotation \| undefined;
		typeParameters: TSTypeParameterDeclaration \| undefined;
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,8 +6,8 @@ import type { Expression } from '../../unions/Expression';

		export interface CallExpression extends BaseNode {
		type: AST_NODE_TYPES.CallExpression;
		typeArguments: TSTypeParameterInstantiation \| undefined;
		arguments: CallExpressionArgument[];
		callee: Expression;
		optional: boolean;
		typeArguments: TSTypeParameterInstantiation \| undefined;
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,8 +5,8 @@ import type { TSTypeAnnotation } from '../../special/TSTypeAnnotation/spec';

		export interface Identifier extends BaseNode {
		type: AST_NODE_TYPES.Identifier;
		typeAnnotation: TSTypeAnnotation \| undefined;
		decorators: Decorator[];
		name: string;
		optional: boolean;
		typeAnnotation: TSTypeAnnotation \| undefined;
		}