typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

feat(eslint-plugin): [naming-convention] add enumMember PascalCase default option#11127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

developer-bandi wants to merge2 commits intotypescript-eslint:main

base:main

Choose a base branch

fromdeveloper-bandi:feat/naming-convention

Open

feat(eslint-plugin): [naming-convention] add enumMember PascalCase default option#11127

developer-bandi wants to merge2 commits intotypescript-eslint:mainfromdeveloper-bandi:feat/naming-convention

Conversation

Copy link

Contributor

developer-bandi commentedMay 4, 2025

PR Checklist

Addresses an existing open issue:fixes[naming-convention] enumMembers should be default PascalCase #7879
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

add enumMember PascalCase default option

feat: naming-convention

a770674

add enumMember PascalCase default option

Copy link

Contributor

typescript-eslintbot commentedMay 4, 2025

Thanks for the PR,@developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMay 4, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4277e2a`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6819afa4feeef40008f65e69
😎 Deploy Preview	https://deploy-preview-11127--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 (🔴 down 5 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedMay 4, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit4277e2a.

Command	Status	Duration	Result
`nx test eslint-plugin`	✅ Succeeded	5m 59s	View ↗
`nx run eslint-plugin:test -- --coverage`	✅ Succeeded	6m 24s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 10s	View ↗
`nx test type-utils`	✅ Succeeded	1s	View ↗
`nx test typescript-eslint`	✅ Succeeded	5s	View ↗
`nx test visitor-keys`	✅ Succeeded	1s	View ↗
`nx run types:build`	✅ Succeeded	1s	View ↗
`nx typecheck ast-spec`	✅ Succeeded	2s	View ↗
`Additional runs (26)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-05-06 06:56:53 UTC

Copy link

codecovbot commentedMay 4, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base(bca8a91) to head(4277e2a).
Report is 50 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11127      +/-   ##==========================================+ Coverage   90.84%   90.91%   +0.07%==========================================  Files         497      499       +2       Lines       50320    50813     +493       Branches     8311     8369      +58     ==========================================+ Hits        45714    46199     +485- Misses       4591     4599       +8  Partials       15       15

Flag	Coverage Δ
unittest	`90.91% <100.00%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts	`97.82% <100.00%> (+0.01%)`	⬆️

... and15 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.