Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(ast-spec): finish migrating tovitest#11126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMay 3, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4f930d1
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/681d7e39794d6000085729c7
😎 Deploy Previewhttps://deploy-preview-11126--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 3, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commit4f930d1.

CommandStatusDurationResult
nx test eslint-plugin✅ Succeeded6m 6sView ↗
nx run eslint-plugin:test -- --coverage✅ Succeeded6m 32sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 2sView ↗
nx test utils✅ Succeeded13sView ↗
nx test scope-manager✅ Succeeded18sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx typecheck ast-spec✅ Succeeded2sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded5sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-05-09 04:16:23 UTC

@aryaemami59aryaemami59 marked this pull request as ready for reviewMay 3, 2025 21:39
@aryaemami59aryaemami59force-pushed thechore/ast-spec-vitest-migration branch from2d1c979 to94a5c9aCompareMay 5, 2025 12:20
@codecovCodecov
Copy link

codecovbot commentedMay 5, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base(e7f5e36) to head(4f930d1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11126   +/-   ##=======================================  Coverage   90.91%   90.91%           =======================================  Files         499      499             Lines       50809    50809             Branches     8369     8369           =======================================  Hits        46195    46195             Misses       4599     4599             Partials       15       15
FlagCoverage Δ
unittest90.91% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMay 5, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🆒

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 5, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commitaeb7402 intotypescript-eslint:mainMay 12, 2025
59 checks passed
@aryaemami59aryaemami59 deleted the chore/ast-spec-vitest-migration branchMay 15, 2025 14:43
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 23, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo(ast-spec): finish migrating tovitest
2 participants
@aryaemami59@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp