chore: revert`vitest` related changes in`tsconfig` files#11124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromaryaemami59:chore/revert-vitest-config-tsconfig-changes

May 2, 2025

Merged

chore: revert`vitest` related changes in`tsconfig` files#11124

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromaryaemami59:chore/revert-vitest-config-tsconfig-changes

May 2, 2025

+15 −17

Conversation

Copy link

Contributor

aryaemami59 commentedMay 1, 2025

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Copy link

Contributor

typescript-eslintbot commentedMay 1, 2025

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

chore: revertvitest related changes intsconfig files

f5d084f

aryaemami59 force-pushed thechore/revert-vitest-config-tsconfig-changes branch from7065634 tof5d084fCompare

May 1, 2025 14:01

Copy link

nx-cloudbot commentedMay 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitfb5b667.

Command	Status	Duration	Result
`nx test eslint-plugin`	✅ Succeeded	6m 23s	View ↗
`nx run eslint-plugin:test -- --coverage`	✅ Succeeded	6m 15s	View ↗
`nx test typescript-eslint`	✅ Succeeded	5s	View ↗
`nx run types:build`	✅ Succeeded	1s	View ↗
`nx typecheck ast-spec`	✅ Succeeded	1s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	41s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 8s	View ↗
`nx run-many --target=clean`	✅ Succeeded	19s	View ↗
`Additional runs (26)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-05-01 14:38:01 UTC

Copy link

netlifybot commentedMay 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`7065634`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/68137eb7b5891b000857b9a2
😎 Deploy Preview	https://deploy-preview-11124--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

netlifybot commentedMay 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`fb5b667`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6813824bcac54e0008bda11c
😎 Deploy Preview	https://deploy-preview-11124--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports