Iguesstoken.getText() is the best API to use to obtain the property name, but I'm unfamiliar with bothtypescript-eslint and TypeScript compiler, so I may well be on the wrong track. Ditto Ithink I've put the test in the right place.

If any changes required (or if I've gone about this in completely the wrong way), please do let me know.

fix(typescript-eslint): correctTSImportType property name when `as…

33db5e9

…sert`

Copy link

Contributor

typescript-eslintbot commentedApr 29, 2025

Thanks for the PR,@overlookmotel!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 29, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`5de0989`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6818d7376a8b5100090f8939
😎 Deploy Preview	https://deploy-preview-11115--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedApr 29, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit5de0989.

Command	Status	Duration	Result
`nx typecheck ast-spec`	✅ Succeeded	3s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	50s	View ↗
`nx run-many --target=clean`	✅ Succeeded	11s	View ↗

☁️Nx Cloud last updated this comment at2025-05-05 15:57:33 UTC

overlookmotel mentioned this pull request

Apr 29, 2025

Bug:TSImportType'soption object always has keywith#11114

Closed

4 tasks

Copy link

codecovbot commentedApr 29, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is0% with13 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base(ccbfcdc) to head(5de0989).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/typescript-estree/src/convert.ts	0.00%	13 Missing⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11115      +/-   ##==========================================- Coverage   90.90%   90.89%   -0.02%==========================================  Files         498      498                Lines       50655    50663       +8       Branches     8335     8335              ==========================================  Hits        46049    46049- Misses       4591     4599       +8  Partials       15       15

Flag	Coverage Δ
unittest	`90.89% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-estree/src/convert.ts	`30.66% <0.00%> (-0.09%)`	⬇️

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

ContributorAuthor

overlookmotel commentedApr 29, 2025

Could someone please advise on how to fix thecodecov/patch CI fail? I'm a bit baffled as the changes made to tests does exercise multiple possible values ofwithOrAssertName. Is it just due to using longer var names?

Copy link

Member

JoshuaKGoldberg commentedMay 2, 2025

Could someone please advise on how to fix thecodecov/patch CI fail? I'm a bit baffled as the changes made to tests does exercise multiple possible values ofwithOrAssertName. Is it just due to using longer var names?

#6701 🫠. This PR is fine, it's the test coverage reporting that's wrong. You can ignore codecov. That's what I'd do (along with an exasperated sigh).

If you want to be awesome and go the extra mile, you could try to fix#6701. 😄

JoshuaKGoldberg requested changes

May 2, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great first PR! 👏

I'm just requesting changes on making a dedicated fixture for this. The text parsing stuff I'm not confident on.

...s/ast-spec/src/type/TSImportType/fixtures/type-import-type-with-import-attributes/fixture.ts OutdatedShow resolvedHide resolved

packages/typescript-estree/src/convert.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

May 2, 2025

overlookmotel added2 commits

May 2, 2025 22:34

Amend fixtures

725831a

Use token kind

7af8e53

Copy link

ContributorAuthor

overlookmotel commentedMay 2, 2025

If you want to be awesome and go the extra mile, you could try to fix#6701. 😄

I aspire to being awesome, but I'm sorry to say I wouldn't have a clue how to do that!

overlookmotel requested a review fromJoshuaKGoldberg

May 2, 2025 21:45

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

May 2, 2025

bradzacher previously approved these changes

May 3, 2025

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - great work!

bradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

May 3, 2025

JoshuaKGoldberg previously approved these changes

May 5, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🙌

Merge branch 'main'

5de0989

JoshuaKGoldberg dismissed stale reviews frombradzacher and themself via5de0989

May 5, 2025 15:20

JoshuaKGoldberg changed the title~~fix(typescript-eslint): correctTSImportType property name whenassert~~fix(typescript-estree): correctTSImportType property name whenassert

May 5, 2025

JoshuaKGoldberg merged commit3c61357 intotypescript-eslint:main

May 5, 2025

56 checks passed