Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: remove jest leftovers#11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kirkwaiblinger merged 3 commits intotypescript-eslint:mainfrom43081j:jestless
Apr 28, 2025

Conversation

43081j
Copy link
Contributor

@43081j43081j commentedApr 15, 2025•
edited by JoshuaKGoldberg
Loading

Removes any leftover jest dependencies and files.

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 15, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit22f637a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/680fdc1fe57a0d0008345d6f
😎 Deploy Previewhttps://deploy-preview-11078--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 15, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit22f637a.

CommandStatusDurationResult
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded4sView ↗
nx run-many --target=clean✅ Succeeded11sView ↗

☁️Nx Cloud last updated this comment at2025-04-28 20:08:37 UTC

Removes any leftover jest dependencies and files.
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesApr 21, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, with the note that there are still some leftovers after this. They're discoverable from searchingjest in the repo excludingCHANGELOG.md files:

  • .gitattributes: a few lines
  • The comment on top ofnx-migrate.yml
  • .vscode/extensions.json &.vscode/launch.json
  • etc.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelApr 21, 2025
kirkwaiblinger
kirkwaiblinger previously approved these changesApr 28, 2025
@kirkwaiblingerkirkwaiblinger dismissed stale reviews fromJoshuaKGoldberg and themself via22f637aApril 28, 2025 19:50
@codecovCodecov
Copy link

codecovbot commentedApr 28, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base(f5c588c) to head(22f637a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11078   +/-   ##=======================================  Coverage   90.83%   90.83%           =======================================  Files         497      497             Lines       50259    50259             Branches     8291     8291           =======================================  Hits        45652    45652             Misses       4592     4592             Partials       15       15
FlagCoverage Δ
unittest90.83% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblingerkirkwaiblingerenabled auto-merge (squash)April 28, 2025 19:52
@kirkwaiblingerkirkwaiblinger merged commit1200571 intotypescript-eslint:mainApr 28, 2025
56 of 57 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@43081j@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp