…y meta keys- `config-helper.ts` only adds base config to config array if it contains keys other than `files`, `ignores`, `names`.- Fixes bug where config helper would create global ignores when extending with base config of `ignores`- Fixes bug where config helper creates extraneous config when extending with base config of only `files`, `ignores`, `names`

Merge branch 'main' into handle-global-ignore-in-config

6c36fe8

fix up edge cases

a674a9d

Copy link

Contributor

typescript-eslintbot commentedApr 14, 2025

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 14, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`c3cd861`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67fd49aaa267db00084a97b0
😎 Deploy Preview	https://deploy-preview-11065--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 7 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedApr 14, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitc3cd861.

Command	Status	Duration	Result
`nx run typescript-eslint:test -- --coverage`	✅ Succeeded	3s	View ↗
`nx run eslint-plugin:test -- --coverage`	✅ Succeeded	1s	View ↗
`nx test typescript-eslint`	✅ Succeeded	2s	View ↗
`nx test utils`	✅ Succeeded	<1s	View ↗
`nx run ast-spec:test -- --coverage`	✅ Succeeded	<1s	View ↗
`nx run types:build`	✅ Succeeded	<1s	View ↗
`nx run visitor-keys:test -- --coverage`	✅ Succeeded	<1s	View ↗
`nx test ast-spec`	✅ Succeeded	<1s	View ↗
`Additional runs (26)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-04-14 17:52:40 UTC

kirkwaiblinger marked this pull request as ready for review

April 14, 2025 06:22

Merge commit '0f9b55d933fca8d5e2bbcba1896d3f68bddb644b' into handle-g…

0731285

…lobal-ignore-in-config

kirkwaiblinger force-pushed thehandle-global-ignore-in-config branch from814670c to0731285Compare

April 14, 2025 06:31

Merge branch 'main' into handle-global-ignore-in-config

3b3a534

JoshuaKGoldberg previously approved these changes

Apr 14, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Apr 14, 2025

Copy link

codecovbot commentedApr 14, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base(b3688be) to head(c3cd861).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11065   +/-   ##=======================================  Coverage   84.31%   84.32%           =======================================  Files         497      497             Lines       27766    27778   +12       Branches     5075     5082    +7     =======================================+ Hits        23411    23423   +12  Misses       4184     4184             Partials      171      171

Flag	Coverage Δ
unittest	`84.32% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/typescript-eslint/src/config-helper.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.