Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): use token type ofNumeric instead ofIdentifier for bigint literals#11021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ronami
Copy link
Member

@ronamironami commentedApr 1, 2025•
edited
Loading

PR Checklist

Overview

This PR addresses#11018 and changes the token type to useNumeric rather thanIdentifier. I added a test to cover this since no tests failed by making this change.

JLHwung reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedApr 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commiteb75aba
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67ec09f82e878800080e2e97
😎 Deploy Previewhttps://deploy-preview-11021--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@ronamironami changed the titlefix(ast-spec): use token type of Numeric instead of Identifier for bigint literalsfix(ast-spec): use token type ofNumeric instead ofIdentifier for bigint literalsApr 1, 2025
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedApr 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commiteb75aba.

CommandStatusDurationResult
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-04-01 21:34:31 UTC

@ronamironami marked this pull request as ready for reviewApril 1, 2025 15:41
@@ -527,6 +527,7 @@ export function getTokenType(

switch (token.kind) {
case SyntaxKind.NumericLiteral:
case SyntaxKind.BigIntLiteral:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since we are here, could you also take a look at#11022? Many thanks.

ronami reacted with heart emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#11023 🎉

@bradzacherbradzacher changed the titlefix(ast-spec): use token type ofNumeric instead ofIdentifier for bigint literalsfix(typescript-estree): use token type ofNumeric instead ofIdentifier for bigint literalsApr 1, 2025
@bradzacherbradzacher merged commitf0072dc intotypescript-eslint:mainApr 1, 2025
60 of 61 checks passed
@ronamironami deleted the bigint-literal-token-type branchApril 1, 2025 21:46
aryaemami59 pushed a commit to aryaemami59/typescript-eslint that referenced this pull requestApr 5, 2025
…ifier` for bigint literals (typescript-eslint#11021)* initial implementation* rename folder
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JLHwungJLHwungJLHwung left review comments

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The token type of a BigInt literal should be Numeric instead of Identifier
3 participants
@ronami@JLHwung@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp