Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [no-deprecated] fix double-report on computed literal identifiers#11006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@undsoft
Copy link
Contributor

PR Checklist

Overview

Adds support for literal member access likea['b']

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@undsoft!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 28, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf710059
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6909037b605398000812224d
😎 Deploy Previewhttps://deploy-preview-11006--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedMar 28, 2025
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable themin workspace settings.


View yourCI Pipeline Execution ↗ for commitf710059

CommandStatusDurationResult
nx run-many -t typecheck❌ Failed2m 12sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 11sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded9sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx run generate-configs✅ Succeeded6sView ↗
nx run-many --target=build --parallel --exclude...✅ Succeeded21sView ↗
Additional runs (28)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-03 19:45:09 UTC

@codecov
Copy link

codecovbot commentedMar 28, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (9530e02) to head (f710059).
⚠️ Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11006      +/-   ##==========================================- Coverage   90.93%   90.66%   -0.28%==========================================  Files         506      518      +12       Lines       51394    52442    +1048       Branches     8482     8690     +208     ==========================================+ Hits        46735    47546     +811- Misses       4646     4882     +236- Partials       13       14       +1
FlagCoverage Δ
unittest90.66% <100.00%> (-0.28%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts96.66% <100.00%> (-0.49%)⬇️

... and40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🙌 Great start, thanks for kicking it off! I think there's just one case around[key] that I think is still missing?

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMar 31, 2025
@undsoft
Copy link
ContributorAuthor

undsoft commentedApr 4, 2025
edited
Loading

@JoshuaKGoldberg
Okay, I've added support for simple identifiers and template strings.

constmyObject={/**@deprecated */recommended:null,};constkey='recommended';constk2='recom';constk3='mended';myObject[key];// WorksmyObject[`${k2}${k3}`];// Works

However, more complex identifiers like:

constmyObject={/**@deprecated */recommended:null,};constkey={nested:'recommended'}asconst;myObject[key.nested];// Doesn't work

are not supported, becausegetPropertyName that I use doesn't seem to understand this construction.

I feel like fixing this may be outside of the scope for this PR? Or otherwise I could use some guidance as to how to do this.

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 4, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Really lovely progress! 💪

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelApr 7, 2025
@JoshuaKGoldberg
Copy link
Member

fixing this may be outside of the scope for this PR?

Agreed, yeah - I think it'd be good as a followup issue.

@undsoft
Copy link
ContributorAuthor

Okay, I believe I've addressed the comments.

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 20, 2025
@kirkwaiblingerkirkwaiblinger changed the titlefix(eslint-plugin): [no-deprecated] support for literal member access (#10958)fix(eslint-plugin): [no-deprecated] support for computed literal member accessApr 28, 2025
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesSep 15, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry for the delay - the summer really got away from us, and I wanted to give this tricky PR the detailed review it deserves. But it looks great - thanks so much for working on it! 😍

@JoshuaKGoldberg
Copy link
Member

I'll handle the merge conflicts so we can ideally merge this in time for the release today.

@JoshuaKGoldberg
Copy link
Member

😬 these are non-trivial merge conflicts. I ran out of time today to try to get this to work.

@undsoft I don't suppose you have bandwidth to fix these up?

@undsoft
Copy link
ContributorAuthor

@JoshuaKGoldberg Hi, at the moment unfortunately I don't have spare time to fix this. I may have time in a couple of months.
It looks like there was a PR for similar functionality that partially implemented was this PR is trying to achieve. It will probably be necessary to re-do this PR.

JoshuaKGoldberg reacted with heart emoji

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You're right, this rule did need redoing because of the merge conflicts. There were really two areas of logic:

  • checkIdentifier: already in existence
  • checkMemberExpression: recently added

...and this addition of usingcheckIdentifier on literals caused double-reporting in quite a few test cases. I ended up removingcheckMemberExpression altogether and merging its new logic intocheckIdentifier.

Someone else from @typescript-eslint/triage-team should review this PR since I'm essentially a co-author on it now.

ronami reacted with eyes emoji
],
},
],
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤔. This is an existing test, from#10867, that no longer passes with the new unified logic. But I now think that it's not correct. TheAllowedType interface is itself what's marked as allowed, not itsprop. I think that that kind ofallow property lookup is separately tracked by#10740.

Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀🚀🚀

@ronamironami added the awaiting responseIssues waiting for a reply from the OP or another party labelSep 29, 2025
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): [no-deprecated] support for computed literal member accessfix(eslint-plugin): [no-deprecated] support for computed literal identifier callsNov 3, 2025
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): [no-deprecated] support for computed literal identifier callsfix(eslint-plugin): [no-deprecated] support for computed literal identifiersNov 3, 2025
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): [no-deprecated] support for computed literal identifiersfix(eslint-plugin): [no-deprecated] fix double-report on computed literal identifiersNov 3, 2025
@JoshuaKGoldberg
Copy link
Member

Ok! You're right, this becomemuch cleaner after a reset onto main. Nice.

ronami reacted with heart emoji

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelNov 3, 2025
Copy link
Member

@ronamironami left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks amazing, thanks! 🚀

JoshuaKGoldberg reacted with rocket emoji
@ronamironami added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 5, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commitc779f3c intotypescript-eslint:mainNov 7, 2025
74 of 77 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestNov 16, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.1 | 8.46.4 || npm        | @typescript-eslint/parser        | 8.46.1 | 8.46.4 |## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
ch4og pushed a commit to csmplay/mapban that referenced this pull requestNov 18, 2025
This PR contains the following updates:| Package | Change | Age | Confidence ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) || [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#&#8203;10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@&#8203;bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#&#8203;11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#&#8203;11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#&#8203;11006](typescript-eslint/typescript-eslint#11006), [#&#8203;10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@&#8203;undsoft](https://github.com/undsoft)- Kentaro Suzuki [@&#8203;sushichan044](https://github.com/sushichan044)- Maria Solano [@&#8203;MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#&#8203;11722](typescript-eslint/typescript-eslint#11722), [#&#8203;11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#&#8203;11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@&#8203;undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#&#8203;11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)##### 🩹 Fixes- **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#&#8203;11667](typescript-eslint/typescript-eslint#11667))- **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#&#8203;11533](typescript-eslint/typescript-eslint#11533))##### ❤️ Thank You- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)##### 🚀 Features- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#&#8203;11659](typescript-eslint/typescript-eslint#11659))- **rule-schema-to-typescript-types:** clean up and make public ([#&#8203;11633](typescript-eslint/typescript-eslint#11633))##### 🩹 Fixes- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#&#8203;11660](typescript-eslint/typescript-eslint#11660))- **typescript-estree:** forbid abstract method and accessor to have implementation ([#&#8203;11657](typescript-eslint/typescript-eslint#11657))- **eslint-plugin:** removed error type previously deprecated ([#&#8203;11674](typescript-eslint/typescript-eslint#11674))- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#&#8203;11603](typescript-eslint/typescript-eslint#11603))- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#&#8203;11634](typescript-eslint/typescript-eslint#11634))- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#&#8203;11628](typescript-eslint/typescript-eslint#11628))- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#&#8203;11487](typescript-eslint/typescript-eslint#11487))##### ❤️ Thank You- fisker Cheung [@&#8203;fisker](https://github.com/fisker)- Josh Goldberg ✨- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- Mark de Dios [@&#8203;peanutenthusiast](https://github.com/peanutenthusiast)- Richard Torres [@&#8203;richardtorres314](https://github.com/richardtorres314)- Victor Genaev [@&#8203;mainframev](https://github.com/mainframev)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#&#8203;11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#&#8203;11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#&#8203;11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@&#8203;thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@&#8203;y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#&#8203;11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#&#8203;11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#&#8203;11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)##### 🚀 Features- **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#&#8203;11267](typescript-eslint/typescript-eslint#11267))##### 🩹 Fixes- **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#&#8203;11490](typescript-eslint/typescript-eslint#11490))##### ❤️ Thank You- Moses Odutusin [@&#8203;thebolarin](https://github.com/thebolarin)- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#&#8203;11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#&#8203;11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#&#8203;11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#&#8203;11423](typescript-eslint/typescript-eslint#11423), [#&#8203;11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#&#8203;11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#&#8203;11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#&#8203;11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#&#8203;11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#&#8203;11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@&#8203;dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@&#8203;mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@&#8203;y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@&#8203;mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)##### 🩹 Fixes- **deps:** update eslint monorepo to v9.33.0 ([#&#8203;11482](typescript-eslint/typescript-eslint#11482))You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)##### 🩹 Fixes- **deps:** update dependency prettier to v3.6.2 ([#&#8203;11496](typescript-eslint/typescript-eslint#11496))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)##### 🚀 Features- **typescript-estree:** forbid invalid keys in `EnumMember` ([#&#8203;11232](typescript-eslint/typescript-eslint#11232))##### ❤️ Thank You- fisker Cheung [@&#8203;fisker](https://github.com/fisker)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4wIiwidXBkYXRlZEluVmVyIjoiNDIuMTAuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->Reviewed-on:https://git.in.csmpro.ru/csmpro/csm-mapban/pulls/20Co-authored-by: Renovate Bot <renovate@csmpro.ru>Co-committed-by: Renovate Bot <renovate@csmpro.ru>
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestNov 19, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm        | @typescript-eslint/parser        | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestNov 19, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm        | @typescript-eslint/parser        | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestNov 20, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm        | @typescript-eslint/parser        | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@ronamironamironami approved these changes

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] does not report on computed member expressions with a known string literal property

3 participants

@undsoft@JoshuaKGoldberg@ronami

[8]ページ先頭

©2009-2025 Movatter.jp