Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fix failing integration tests on deprecation plugin#11002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromKuSh:fix-10992
Mar 31, 2025

Conversation

KuSh
Copy link
Contributor

@KuShKuSh commentedMar 27, 2025•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Fix test failures by marking eslint-plugin-deprecation usage as expecting ts failures

Co-authored-by:@aryaemami59

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@KuSh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 27, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit25f21a1.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded3sView ↗
nx run-many --target=clean✅ Succeeded11sView ↗

☁️Nx Cloud last updated this comment at2025-03-27 19:30:51 UTC

@netlifyNetlify
Copy link

netlifybot commentedMar 27, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit25f21a1
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67e5909561abd20008244e3a
😎 Deploy Previewhttps://deploy-preview-11002--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@KuShKuSh changed the titlefix(integration-tests): test failuresfix: test failuresMar 27, 2025
@KuShKuSh changed the titlefix: test failuresfix: integration test failuresMar 27, 2025
@KuShKuSh changed the titlefix: integration test failuresfix: integration tests failureMar 27, 2025
compat.config(deprecationPlugin.configs.recommended),
...compat.config(jestPlugin.configs.recommended),
);
tseslint.config(
// @ts-expect-error
deprecationPlugin.configs.recommended,
// this should error but doesn't because there are no types exported from the jest plugin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ACK - nice to see the plugin has types now 🙂

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for the CI cleanup!

I put a co-author attribution in the description because#10999 was sent a few hours earlier than this PR with similar changes. This one is smaller and works so I'll merge this one as-is.

KuSh reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix: integration tests failurechore: fix failing integration tests on deprecation pluginMar 31, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit953294d intotypescript-eslint:mainMar 31, 2025
72 of 73 checks passed
@KuSh
Copy link
ContributorAuthor

LGTM, thanks for the CI cleanup!

I put a co-author attribution in the description because#10999 was sent a few hours earlier than this PR with similar changes. This one is smaller and works so I'll merge this one as-is.

Oh didn't saw that there was another PR. No problem for shared attribution though!

@KuShKuSh deleted the fix-10992 branchMarch 31, 2025 13:35
aryaemami59 pushed a commit to aryaemami59/typescript-eslint that referenced this pull requestApr 5, 2025
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Integration test failure onmain:flat-config-types-@types__eslint-v8 &-v9
2 participants
@KuSh@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp