typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

feat(eslint-plugin): [prefer-nullish-coalescing] create`ignoreIfStatements` option#11000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromOlivierZal:prefer-nullish-coalescing-10995

Mar 31, 2025

Merged

feat(eslint-plugin): [prefer-nullish-coalescing] create`ignoreIfStatements` option#11000

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromOlivierZal:prefer-nullish-coalescing-10995

Mar 31, 2025

+129 −8

Conversation

Copy link

Contributor

OlivierZal commentedMar 27, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement: [prefer-nullish-coalescing] should allow if statement assignment (??=) to be optional #10995
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

feat(eslint-plugin): [prefer-nullish-coalescing] create `ignoreIfStat…

4e2694b

…ements` option

Copy link

Contributor

typescript-eslintbot commentedMar 27, 2025

Thanks for the PR,@OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 27, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`74b5b47`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67e56f053e97fb0008967036
😎 Deploy Preview	https://deploy-preview-11000--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 85 (🔴 down 14 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

OlivierZal changed the title~~feat(eslint-plugin): [prefer-nullish-coalescing] create `ignoreIfStat…~~feat(eslint-plugin): [prefer-nullish-coalescing] createignoreIfStatements option

Mar 27, 2025

Copy link

nx-cloudbot commentedMar 27, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit74b5b47.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	6s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️Nx Cloud last updated this comment at2025-03-27 15:48:19 UTC

JoshuaKGoldberg previously approved these changes

Mar 27, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

⚡

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Mar 27, 2025

OlivierZal added2 commits

March 27, 2025 14:24

Merge branch 'main' into prefer-nullish-coalescing-10995

2e962f6

sorting

221e866

OlivierZal dismissedJoshuaKGoldberg’sstale review via221e866

March 27, 2025 13:49

update snapshots

74b5b47

Copy link

ContributorAuthor

OlivierZal commentedMar 27, 2025

@kirkwaiblinger, FYI

Copy link

codecovbot commentedMar 27, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base(5b187f4) to head(74b5b47).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #11000   +/-   ##=======================================  Coverage   88.04%   88.04%           =======================================  Files         470      470             Lines       16793    16793             Branches     4744     4744           =======================================  Hits        14786    14786             Misses       1662     1662             Partials      345      345

Flag	Coverage Δ
unittest	`88.04% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`96.68% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ronami approved these changes

Mar 30, 2025

View reviewed changes

kirkwaiblinger approved these changes

Mar 31, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for taking care of this@OlivierZal!!

Copy link

Member

kirkwaiblinger commentedMar 31, 2025

Might need to bypass the integration tests (failing on main) in order to merge this one before next release@JoshuaKGoldberg

JoshuaKGoldberg merged commitada32d1 intotypescript-eslint:main

Mar 31, 2025

55 of 57 checks passed

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Apr 1, 2025

Update typescript-eslint monorepo to v8.29.0

341480a

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 || npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))##### 🩹 Fixes-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))##### ❤️ Thank You-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   Yannick Decat [@mho22](https://github.com/mho22)-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))##### 🩹 Fixes-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Yannick Decat [@mho22](https://github.com/mho22)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Apr 1, 2025

Update typescript-eslint monorepo to v8.29.0

74b4b8f

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 || npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))##### 🩹 Fixes-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))##### ❤️ Thank You-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   Yannick Decat [@mho22](https://github.com/mho22)-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))##### 🩹 Fixes-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Yannick Decat [@mho22](https://github.com/mho22)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

aryaemami59 pushed a commit to aryaemami59/typescript-eslint that referenced this pull request

Apr 5, 2025

feat(eslint-plugin): [prefer-nullish-coalescing] create `ignoreIfStat…

961c9d4

…ements` option (typescript-eslint#11000)* feat(eslint-plugin): [prefer-nullish-coalescing] create `ignoreIfStatements` option* sorting* update snapshots