Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): don’t markdeclare class as unused#110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
j-f1 merged 2 commits intomasterfromdeclare-class-is-used
Jan 22, 2019

Conversation

j-f1
Copy link
Contributor

Fixes#106.

@j-f1j-f1 requested a review fromarmano2January 21, 2019 20:04
@codecov
Copy link

codecovbot commentedJan 21, 2019
edited
Loading

Codecov Report

Merging#110 intomaster willincrease coverage by0.01%.
The diff coverage is100%.

@@           Coverage Diff            @@##           master   #110      +/-   ##========================================+ Coverage   94.99%    95%   +0.01%========================================  Files          48     48                Lines        2479   2484       +5       Branches      381    381              ========================================+ Hits         2355   2360       +5  Misses         75     75                Partials       49     49
Impacted FilesCoverage Δ
packages/eslint-plugin/lib/rules/no-unused-vars.js100% <100%> (ø)⬆️

Copy link
Collaborator

@armano2armano2 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this will fix issue withdeclare class Foo but it will not solve false positives from#106 (comment)

for sure this is improvement and with this small request aboutelse everything looks fine

@j-f1j-f1 merged commit5841cd2 intomasterJan 22, 2019
@j-f1j-f1 deleted the declare-class-is-used branchJanuary 22, 2019 12:39
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unused-vars] Don’t markdeclare class expressions as unused
2 participants
@j-f1@armano2

[8]ページ先頭

©2009-2025 Movatter.jp