Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): don’t markdeclare class
as unused#110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedJan 21, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #110 +/- ##========================================+ Coverage 94.99% 95% +0.01%======================================== Files 48 48 Lines 2479 2484 +5 Branches 381 381 ========================================+ Hits 2355 2360 +5 Misses 75 75 Partials 49 49
|
armano2 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this will fix issue withdeclare class Foo
but it will not solve false positives from#106 (comment)
for sure this is improvement and with this small request aboutelse
everything looks fine
Uh oh!
There was an error while loading.Please reload this page.
Fixes#106.