Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fix failingintegration-tests on Windows#10999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

@aryaemami59aryaemami59 commentedMar 27, 2025•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 27, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitd2ce3b3
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67f97e9f5a3ecc0008c4eff5
😎 Deploy Previewhttps://deploy-preview-10999--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 91 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 27, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitd2ce3b3.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded1sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-04-11 21:01:58 UTC

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMar 31, 2025
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commentedMar 31, 2025•
edited
Loading

Note: I merged#11002 and gave it a co-author attribution since it's a subset of this one and also passes.

@codecovCodecov
Copy link

codecovbot commentedMar 31, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base(0f9b55d) to head(d2ce3b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10999   +/-   ##=======================================  Coverage   87.68%   87.68%           =======================================  Files         486      486             Lines       15910    15910             Branches     4602     4602           =======================================  Hits        13950    13950             Misses       1615     1615             Partials      345      345
FlagCoverage Δ
unittest87.68% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59aryaemami59 changed the titlechore: fix failingintegration-testschore: fix failingintegration-tests on WindowsApr 2, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 2, 2025
@aryaemami59aryaemami59force-pushed thechore/fix-integration-tests branch from6c630a3 to85eb947CompareApril 7, 2025 18:46
bradzacher
bradzacher previously approved these changesApr 10, 2025
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for fixing this! Legend.

ilikeit.gif

aryaemami59 reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitfa265a9 intotypescript-eslint:mainApr 11, 2025
59 checks passed
@aryaemami59aryaemami59 deleted the chore/fix-integration-tests branchApril 11, 2025 21:52
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Integration test failure onmain:flat-config-types-@types__eslint-v8 &-v9
3 participants
@aryaemami59@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp