Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-deprecated] report on deprecated imported variable used as property#10998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ronami
Copy link
Member

PR Checklist

Overview

This PR addresses#10828 and adjusts the rule to also check the alias chain for a possible deprecation.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 26, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitcecaeda
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67eaf86eb6f3680008327631
😎 Deploy Previewhttps://deploy-preview-10998--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 100 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 26, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitcecaeda.

CommandStatusDurationResult
nx test eslint-plugin✅ Succeeded8m 12sView ↗
nx run eslint-plugin:test -- --coverage✅ Succeeded6m 12sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded6m 27sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded18sView ↗
nx test typescript-eslint✅ Succeeded4sView ↗
nx run-many --target=clean✅ Succeeded17sView ↗
nx test eslint-plugin-internal✅ Succeeded<1sView ↗
Additional runs (25)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-03-31 20:34:58 UTC

@codecovCodecov
Copy link

codecovbot commentedMar 26, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base(3dd1835) to head(19f2193).

❗Current head19f2193 differs from pull request most recent headcecaeda

Pleaseupload reports for the commitcecaeda to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10998      +/-   ##==========================================- Coverage   88.03%   88.02%   -0.01%==========================================  Files         470      470                Lines       16801    16790      -11       Branches     4745     4742       -3     ==========================================- Hits        14790    14780      -10  Misses       1664     1664+ Partials      347      346       -1
FlagCoverage Δ
unittest88.02% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts94.59% <100.00%> (ø)

... and6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronamironami marked this pull request as ready for reviewMarch 26, 2025 22:42
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 LGTM, thanks!

ronami reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 31, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit04abebc intotypescript-eslint:mainApr 7, 2025
55 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestApr 9, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.29.0 | 8.29.1 || npm        | @typescript-eslint/parser        | 8.29.0 | 8.29.1 |## [v8.29.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8291-2025-04-07)##### 🩹 Fixes-   **eslint-plugin:** \[no-deprecated] report on deprecated imported variable used as property ([#10998](typescript-eslint/typescript-eslint#10998))##### ❤️ Thank You-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestApr 12, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.29.0 | 8.29.1 || npm        | @typescript-eslint/parser        | 8.29.0 | 8.29.1 |## [v8.29.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8291-2025-04-07)##### 🩹 Fixes-   **eslint-plugin:** \[no-deprecated] report on deprecated imported variable used as property ([#10998](typescript-eslint/typescript-eslint#10998))##### ❤️ Thank You-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestApr 13, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.29.0 | 8.29.1 || npm        | @typescript-eslint/parser        | 8.29.0 | 8.29.1 |## [v8.29.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8291-2025-04-07)##### 🩹 Fixes-   **eslint-plugin:** \[no-deprecated] report on deprecated imported variable used as property ([#10998](typescript-eslint/typescript-eslint#10998))##### ❤️ Thank You-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] Deprecated imported variable used in an object not detected/reported
2 participants
@ronami@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp